You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
THP usage regression after aligned metadata optimization for faster frees #1502
It looks like THP usage regressed after optimizing free with aligned page metadata. The second commit of this work effort introduces an fallback to allocate from the OS directly with allow_large=false. In version 3, allow_large=false disables the THP page hint. So, these pages don't get a THP hint. This leads to a major regression in one of our workloads (a TPC-DS benchmark query regresses from 13.5s to 18s) due to more page faults.
This PR against version 2 of mimalloc reasons why allow_large=false should not be involved in deciding the THP hint. Could you check if the same fix should be applied to version 3 now?
Thanks for the fast fix! Out of interest when do you expect to release this? It's not urgent from our site. I'm more wondering what's the general rule for a new patch release.
Activity
fix THP usage regression in v3 (now the same as v2 again), issue #1502
Fix THP advice eligibility for OS allocations (related to #1502)
daanx commentedon Nov 18, 2026
Thanks Per -- good catch; not sure how this regressed back :-( Fixed now, and also improved the eligibility check.
PerFuchs commentedon Nov 19, 2026
Thanks for the fast fix! Out of interest when do you expect to release this? It's not urgent from our site. I'm more wondering what's the general rule for a new patch release.