Skip to content

fix(form): preserve whitespace in field names - #893

Merged
Vincent Biret (baywet) merged 1 commit into
microsoft:mainfrom
Muneer320:fix/form-field-name-whitespace
Nov 13, 2026
Merged

Vincent Biret (baywet) merged 1 commit into
microsoft:mainfrom
Muneer320:fix/form-field-name-whitespace

Conversation

@Muneer320

Copy link
Copy Markdown
Contributor

Overview

Form serialization trims field names, so field and field are sent under the same name. Encode the original name in the string, object and non-parsable-object writer paths.

Regressions cover leading/trailing ASCII whitespace, whitespace-only names, Unicode whitespace, distinct-field preservation and public parser lookup. Ordinary names and names requiring percent-encoding remain covered. Existing empty/absent input behavior is unchanged.

Related Issue

Fixes #892.

Testing Instructions

  • From packages/serialization/form, install requirements-dev.txt and run pytest.
  • Before the source fix, eight new regression cases fail and four new controls pass.
  • After the fix, all 149 form-package tests pass locally on Windows/CPython 3.13.7.
  • YAPF, isort and mypy pass. Pylint exits 0 with the existing suggestion-mode configuration diagnostic; its optional cache could not be written in the local sandbox.

The public reproducer and tests use local serialization only. No service calls or credentials are required.

@Muneer320
Muneer Alam (Muneer320) requested a review from a team as a code owner November 11, 2026 20:27
Copilot AI balanced review requested due to automatic review settings November 11, 2026 20:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change preserving whitespace in serialized form field names.

No open issues 🎉

Review effort: Balanced

@github-project-automation github-project-automation Bot moved this to In Progress 🚧 in Kiota Nov 12, 2026
@Muneer320

Copy link
Copy Markdown
Contributor Author

Thanks for the review. Build and Test and CodeQL are marked startup_failure; Build and Test created zero jobs. CLA and SonarCloud pass. Could a maintainer check or re-run those workflows? The PR description includes the 149 passing local form tests and the eight regressions that failed before the fix.

@baywet

Copy link
Copy Markdown
Member

I did try requeuing with the same result. I submitted a support ticket to GitHub since there's officially "no outage going on". Let's see what they reply.

@baywet

Copy link
Copy Markdown
Member

(closing to get around the actions run issue, will re-open immediately)

auto-merge was automatically disabled November 13, 2026 12:31

Pull request was closed

@github-project-automation github-project-automation Bot moved this from In Progress 🚧 to Done ✔️ in Kiota Nov 13, 2026
@github-project-automation github-project-automation Bot moved this from Done ✔️ to In Progress 🚧 in Kiota Nov 13, 2026
@sonarqubecloud

Copy link
Copy Markdown

@baywet
Vincent Biret (baywet) added this pull request to the merge queue Nov 13, 2026
Merged via the queue into microsoft:main with commit 1cc664f Nov 13, 2026
130 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress 🚧 to Done ✔️ in Kiota Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done ✔️

Development

Successfully merging this pull request may close these issues.

Form serialization trims field names and merges distinct fields

3 participants