Skip to content
This repository was archived by the owner on Oct 14, 2024. It is now read-only.
This repository was archived by the owner on Oct 14, 2024. It is now read-only.

http - align OTEL http attributes with latest standard #409

Closed

Description

@baywet

to maintain compatibility with external tooling we should make sure our attribute respect the latest (stable) semantic conventions. When we initially implemented things, the spec was still in draft. The following attributes need to be renamed in the middleware handlers and in the request adapter:
htttp.status_code => http.response.status_code
http.response_content_length => http.response.body.size
http.request_content_length => http.request.body.size
http.flavor => network.protocol.name
http.response_content_type => http.response.header.content-type
http.request_content_type => http.request.header.content-type
http.method => http.request.method
http.host => url.scheme
http.scheme => server.address
http.uri => url.full
http.uri_template => url.uri_template

link to the spec for more information https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/
related microsoftgraph/msgraph-sdk-design#108

Activity

  1. moved this to Needs Triage 🔍 in Kiotaon Aug 27, 2024
  2. moved this from Needs Triage 🔍 to Todo 📃 in Kiotaon Aug 27, 2024
  3. moved this from Todo 📃 to Done ✔️ in Kiotaon Oct 11, 2024
  4. sdarmofal commented on Oct 14, 2024

    @sdarmofal

    Hey. There's a problem with this change. The kiota-http-python doesn't work with opentelemetry in version 1.23. As https://github.com/microsoft/kiota-http-python/blob/main/pyproject.toml says it should work with opentelemetry >1.20.0 that's not true.

  5. baywet commented on Oct 14, 2024

    @baywet
    MemberAuthor

    Hi Szymon Darmofał (@sdarmofal)
    Thanks for pointing this out.
    Can you open a separate issue please and expand a little on the problem you're facing?
    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    WIPbugSomething isn't workinghelp wantedStandard GitHub labeltype:bugA broken experience

    Type

    No type

    Projects

    • Status
      Done ✔️

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions