You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 14, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 14, 2024. It is now read-only.
http - align OTEL http attributes with latest standard #409
to maintain compatibility with external tooling we should make sure our attribute respect the latest (stable) semantic conventions. When we initially implemented things, the spec was still in draft. The following attributes need to be renamed in the middleware handlers and in the request adapter:
htttp.status_code => http.response.status_code
http.response_content_length => http.response.body.size
http.request_content_length => http.request.body.size
http.flavor => network.protocol.name
http.response_content_type => http.response.header.content-type
http.request_content_type => http.request.header.content-type
http.method => http.request.method
http.host => url.scheme
http.scheme => server.address
http.uri => url.full
http.uri_template => url.uri_template
Hi Szymon Darmofał (@sdarmofal)
Thanks for pointing this out.
Can you open a separate issue please and expand a little on the problem you're facing?
Thanks!
Activity
sdarmofal commentedon Oct 14, 2024
Hey. There's a problem with this change. The
kiota-http-pythondoesn't work with opentelemetry in version 1.23. As https://github.com/microsoft/kiota-http-python/blob/main/pyproject.toml says it should work with opentelemetry>1.20.0that's not true.baywet commentedon Oct 14, 2024
Hi Szymon Darmofał (@sdarmofal)
Thanks for pointing this out.
Can you open a separate issue please and expand a little on the problem you're facing?
Thanks!