Repository navigation
Add files via upload - #2
Open
CEXU FU (cexufu) wants to merge 1 commit into
Open
CEXU FU (cexufu) wants to merge 1 commit into
CEXU FU (cexufu) wants to merge 1 commit into
Conversation
Fix schema-compatible variable references in tutorial planner
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variable-reference arguments produced by
make_custom_generator()use{"kind": "variable_name", "value": "ref1"}, butVariablePassingPlanner._expand_args()only accepts{"kind": "variable", "variable": "ref1"}. Passing a schema-compatible reference therefore raisesAssertionError: Invalid kind for argument message: variable_namebefore the referenced value can reach the tool.This change adds the missing
variable_namebranch and resolves its reference through thevaluefield, while preserving the existing literal and legacy-reference branches.A model-free check cell covers literal arguments, schema-compatible references, legacy references, and mixed arguments. Additional local checks confirmed that unknown references and unsupported kinds still raise errors, and that the regression input matches the actual schema generator.
Validation: the check cell reproduces the assertion on the original implementation and passes after the fix. All notebook code cells compile; existing outputs and metadata are preserved. Validation was performed by executing the relevant notebook class and check cell in isolation, without Azure/OpenAI calls. The complete notebook was not rerun against a live model.