[Hardik K (hardikkaurani)]

Summary

• Implements __hash__ for EntityInstanceId using hash((self.entity, self.key)), allowing instances to be stored in sets and used as dictionary keys without raising TypeError: unhashable type.
• Implements __repr__ to provide readable, informative debugging output.
• Adds unit tests covering hash consistency with case-insensitive entity normalization, set deduplication, dictionary key lookups, and repr formatting.
• Updates CHANGELOG.md under the Unreleased section.

Validation

• All 1,345 durabletask unit and integration tests passed with zero regressions.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Hardik K (hardikkaurani)]

Hi Bernd Verst (@berndverst),

I've opened this focused PR to implement __hash__ and __repr__ on EntityInstanceId.

Previously, EntityInstanceId instances were unhashable because __eq__ was defined without a corresponding __hash__ implementation. This prevented instances from being used in sets or as dictionary keys.

This PR addresses the issue and adds a readable representation for EntityInstanceId instances.

All 1,345 unit and integration tests pass, with zero regressions.

Whenever you have a chance, could you please review it? Thank you for your time!

[Copilot]

🟡 Changes recommended

Writable identity fields can change an instance’s hash after insertion and invalidate dictionary or set lookups.

1 open issue

• Prevent hash changes from mutable equality fields · New

_{Review effort: Balanced}

[Hardik K (hardikkaurani)]

Hi Bernd Verst (@berndverst),

I've addressed the review feedback by enforcing immutability on EntityInstanceId to guarantee hash stability.

• Immutability via __slots__ and read-only properties: Internal state is stored in _entity and _key during initialization. Attempts to reassign or delete entity or key, or attach arbitrary attributes, raise AttributeError.
• Copy and pickle support: Added __copy__, __deepcopy__, and __reduce__ to support copying and pickling immutable instances.
• Regression tests: Added comprehensive tests in test_entity_id_parsing.py covering rejected attribute mutation and deletion, stable dictionary and set lookups, and copy/pickle operations.
• Test suite: All unit and integration tests pass, with zero regressions.

All review feedback has been addressed. Whenever you have a chance, could you please take another look? Thank you for your time and feedback!

[Hardik K (hardikkaurani)]

andystaples Check it once if you have a chance ! Thank you !

[Hardik K (hardikkaurani)]

Hi andystaples,

Thank you for identifying the pickle compatibility issue.

I've updated the reconstruction logic in EntityInstanceId.__reduce__ to use type(self) so that the concrete runtime type is preserved across pickle round-trips. I also added regression coverage for both the core EntityInstanceId subclass hierarchy and the Azure Functions EntityId compatibility class. The tests verify that pickling and unpickling preserve the subclass identity and .name property, while the existing EntityInstanceId hash-stability and immutability guarantees remain fully intact.

Validation

• Targeted regression tests:
  • pytest tests/durabletask/entities/test_entity_id_parsing.py: 11 passed (including test_entity_instance_id_subclass_pickle)
  • pytest tests/azure-functions-durable/test_client_compat.py -k test_entity_id: 3 passed (including test_entity_id_pickle_round_trip)
• Related compatibility tests:
  • pytest tests/azure-functions-durable/test_client_compat.py: 98 passed
  • nox -s functions_unit-3.13: 407 passed
• Lint & Static Type Analysis:
  • nox -s lint: passed (flake8 clean, 0 issues)
  • Strict pyright checks: 0 errors, 0 warnings across core durabletask/entities and azure-functions-durable

The changes have been pushed to the existing PR branch fix/entity-instance-id-hash-repr in commit 83948ee. I appreciate your review and would be grateful if you could take another look.

[andystaples]

Merged, thanks Hardik K (@hardikkaurani) !

[Hardik K (hardikkaurani)]

andystaples Thanks a lot for your guidence and review.