Repository navigation
Updates released with --outputDir option loses codesign signature #544
Description
Hi, thanks for a great library which was one of the main reasons my company switched to React Native.
I realized from deployment history that recent updates haven't been installed nor downloaded, and code-signed iOS app log contains following error message:
Error! Public key was provided but there is no JWT signature within app bundle to verify
After some investigation, we found that the problem only occurs when the update was released with option --outputDir AND --privateKeyPath. For example:
code-push release-react myapp-ios ios --outputDir build --privateKeyPath ~/myapp-codepush-private.pem
I looked into build folder where the output were generated and file .codepushrelease file was there. It seems the update had lost this file somehow when it reached the client.
If I omit --outputDir build, the client receives and apply the update successfully.
We need --outputDir option for crash reporting service. Currently we generate the output manually, but it would be nice being able to do it along with CodePush release.
CodePush CLI version: 2.1.4
react-native-code-push version: 5.2.1
Activity
sergey-akhalkov commentedon Dec 11, 2017
Hi Rasita Satianrapapong (@PaperMonster), thanks for reporting the issue! I'm going to investigate it and let you know if I have any results or questions, thanks for the patience.
fix issue w/ outputDir in case of using code-signing
sergey-akhalkov commentedon Dec 12, 2017
Hi Rasita Satianrapapong (@PaperMonster), could you please take a look at #545 and let me know if it works for you or not? Also let me know if you see any issues or have any questions.
PaperMonster commentedon Dec 12, 2017
Sergey Akhalkov (@sergey-akhalkov) Thanks for quick response and the fix! I followed Build section in README including running
gulp linkbut were uncertain where is the correct binary to run. Is it justcode-pushor the absolute path?.sergey-akhalkov commentedon Dec 12, 2017
Rasita Satianrapapong (@PaperMonster), to test the fix you can follow these instructions:
cd code-pushgulp buildcd cli/binnpm installcode-push release-react myapp-ios ios --outputDir build --privateKeyPath ~/myapp-codepush-private.pemPlease let me know if you have any questions or see any issues.
PaperMonster commentedon Dec 13, 2017
Sergey Akhalkov (@sergey-akhalkov) The fix works beautifully. Thank you for your hard work. 👍
sergey-akhalkov commentedon Dec 13, 2017
Rasita Satianrapapong (@PaperMonster), thanks, good to know it works, going to publish an release at the end of this or in the beginning of the next week.
fix issue w/ outputDir in case of using code-signing (#545)
max-mironov commentedon Dec 19, 2017
Hey Rasita Satianrapapong (@PaperMonster) we have release new version of code push https://github.com/Microsoft/code-push/releases/tag/v2.1.5
Please let us know if you see any issues.