[Eduard van Valkenburg (eavanvalkenburg)]

Motivation & Context

Make settings-value behavior more consistent across Python formatting and provider integrations.

Description & Review Guide

• What are the major changes? Refine SecretString behavior and align provider credential handling and type annotations.
• What is the impact of these changes? SecretString is now a value wrapper rather than a str subclass. Callers needing a plain string should use get_secret_value(). Plain-string settings inputs remain supported.
• What do you want reviewers to focus on? Consistent settings behavior and compatibility at provider boundaries.

Related Issue

N/A.

Contribution Checklist

• The code builds clean without any errors or warnings
• All unit tests pass, and I have added new tests where possible
• The PR follows the Contribution Guidelines
• This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
• This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.

[Copilot]

🟡 Changes recommended

The hashable wrapper remains mutable, and public OpenAI constructor annotations still reject supported SecretString values.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Refines Python secret handling by making SecretString a masked value wrapper and explicitly unwrapping credentials at provider SDK boundaries.

Changes:

• Adds masked formatting, concatenation, equality, and validation semantics.
• Updates provider credential annotations and SDK integrations.
• Expands tests across supported providers.

File summaries

File	Description
python/packages/core/agent_framework/_settings.py	Implements the new wrapper and coercion.
python/packages/core/tests/core/test_settings.py	Tests masking and value semantics.
python/packages/core/AGENTS.md	Documents settings conventions.
python/packages/openai/tests/openai/test_openai_shared.py	Tests SDK-boundary unwrapping.
python/packages/mistral/tests/mistral/test_mistral_embedding_client.py	Tests embedding credentials.
python/packages/mistral/tests/mistral/test_mistral_chat_client.py	Tests chat credentials.
python/packages/gemini/agent_framework_gemini/_chat_client.py	Accepts wrapped API keys.
python/packages/gemini/tests/test_gemini_client.py	Tests Gemini key resolution.
python/packages/bedrock/agent_framework_bedrock/_chat_client.py	Updates credential annotations.
python/packages/bedrock/agent_framework_bedrock/_embedding_client.py	Updates credential annotations.
python/packages/bedrock/tests/test_bedrock_client.py	Tests session credential unwrapping.
python/packages/azure-cosmos/agent_framework_azure_cosmos/_history_provider.py	Unwraps Cosmos credentials.
python/packages/azure-cosmos/agent_framework_azure_cosmos/_checkpoint_storage.py	Unwraps checkpoint credentials.
python/packages/azure-cosmos/tests/test_cosmos_history_provider.py	Tests history credentials.
python/packages/azure-cosmos/tests/test_cosmos_checkpoint_storage.py	Tests checkpoint credentials.
python/packages/azure-ai-search/agent_framework_azure_ai_search/_context_provider.py	Supports wrapped search keys.
python/packages/azure-ai-search/tests/test_aisearch_context_provider.py	Tests search key boundaries.
python/packages/anthropic/agent_framework_anthropic/_chat_client.py	Accepts wrapped API keys.
python/packages/anthropic/agent_framework_anthropic/_foundry_client.py	Accepts wrapped Foundry keys.
python/packages/anthropic/agent_framework_anthropic/_bedrock_client.py	Accepts wrapped AWS credentials.
python/packages/anthropic/tests/test_anthropic_client.py	Tests Anthropic key handling.
python/packages/anthropic/tests/test_anthropic_provider_clients.py	Tests provider credential boundaries.

Review details

• Files reviewed: 22/22 changed files
• Comments generated: 2
• Review effort level: Balanced

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

MAF Automated Review — Iteration 1

Result: Findings reported
Scope: full PR (1 commit(s)): 4ceefd0b6ff1
Model: gpt-5.6-sol-fast

Overview

The PR replaces the str subclass with a masking value wrapper and adds explicit unwrapping at most provider SDK boundaries, backed by broad settings and provider tests. The masking, coercion, and direct SDK-boundary guards are strong, but the provider migration is incomplete: Foundry embeddings reject wrapped credentials at runtime, while the public OpenAI client signatures reject them during static checking despite runtime support.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
2 verified findings remained after source verification (2 medium) across 1 file. Details are attached to the affected lines below.

Affected areas: python/packages/core/agent_framework/_settings.py