Repository navigation
Fix sleep between retries of startRecordingScreen - #603
Merged
Merged
Conversation
Le Zhou (zhou9584)
approved these changes
Sep 26, 2023
Member
|
/azp run |
|
No pipelines are associated with this pull request. |
Member
|
David Asulin (@DavidAsulin1) thank you for the contribution! you may need to agree to microsoft-github-policy by commenting: @microsoft-github-policy-service agree |
Member
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
@microsoft-github-policy-service agree |
Member
|
/azp run |
|
No pipelines are associated with this pull request. |
Nathan (hydraxman)
enabled auto-merge (squash)
September 27, 2023 01:18
Nathan (hydraxman)
approved these changes
Sep 27, 2023
Member
|
Do we know why this keeps hanging in this state? Le Zhou (@zhou9584) OliverShen (@olivershen-wow) AichiB7A (@TedaLIEz)
|
AichiB7A (TedaLIEz)
added a commit
that referenced
this pull request
Sep 27, 2023
This reverts commit 4d24a70.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A minor fix for the sleep time between
startRecordingScreen. TheretryAndSleepWhenFalsetakes sleepSeconds param and it's set to 1000 second (probably a mistake). I changed the value to 10 second (align with the other usages of this method).Pull Request Checklist
Does this introduce a breaking change?
How you tested it
I encounter an issue running test on a mac machine. If appium failed to start the recording the
retryAndSleepWhenFalseenter a very long sleep of 1000 seconds which block the test. Changing the value to 10 second (align with the other usages of this method) did fix the issue.Please check the type of change your PR introduces: