Skip to content

Update more diagnostic messages ES6->2015 - #9065

Merged
Mohamed Hegazy (mhegazy) merged 1 commit into
microsoft:masterfrom
texastoland:8996-es6-diagnostic-messages
Jun 10, 2016
Merged

Mohamed Hegazy (mhegazy) merged 1 commit into
microsoft:masterfrom
texastoland:8996-es6-diagnostic-messages

Conversation

@texastoland

Copy link
Copy Markdown
Contributor

@msftclas

Hi @AppShipIt, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@texastoland

Texas Toland (texastoland) commented Jun 10, 2016 •

Copy link
Copy Markdown
Contributor Author

Passed locally I must need to rebase…

@mhegazy
Mohamed Hegazy (mhegazy) merged commit 6687f2c into microsoft:master Jun 10, 2016
@mhegazy

Copy link
Copy Markdown
Contributor

thanks!

@mhegazy

Copy link
Copy Markdown
Contributor

For future references, files under lib\ are generated by jake LKG, and not updated in PRs.

@texastoland

Texas Toland (texastoland) commented Jun 10, 2016 •

Copy link
Copy Markdown
Contributor Author

Curious because those did look generated. So they're not intended to be versioned?

@mhegazy

Copy link
Copy Markdown
Contributor

We refresh them regularly. but off master.

@texastoland

Copy link
Copy Markdown
Contributor Author

Makes sense thanks!

@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants