Repository navigation
Baselining smaller changes in transformation-based emit - #7814
Closed
Daniel Rosenwasser (DanielRosenwasser) wants to merge 2 commits into
Closed
Daniel Rosenwasser (DanielRosenwasser) wants to merge 2 commits into
Daniel Rosenwasser (DanielRosenwasser) wants to merge 2 commits into
Conversation
| function C234() { | ||
| this[0] = 1; | ||
| this[0.0] = 2; | ||
| this[0] = 2; |
Contributor
There was a problem hiding this comment.
This is an error, it should be using the raw literal text. I have a similar issue with binary/octal integers I need to investigate. I wouldn't accept the baseline for this file.
Ron Buckton (rbuckton)
added
the
Domain: API: Transforms
Contributor
|
Daniel Rosenwasser (@DanielRosenwasser) do not think this is needed any longer. if this is not true, please update. |
Mohamed Hegazy (mhegazy)
deleted the
512-acceptable-baselining-transforms
branch
April 18, 2016 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ron Buckton (@rbuckton)