Fix flaky diagnostic added by emit for typeof import() type qualifiers - #64636
Open
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Open
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
| for ast.IsPropertyAccessOrQualifiedName(topProp) { | ||
| if ast.IsPartOfTypeNode(topProp) { | ||
| // Names in an import type's qualifier (`ns.y` in `typeof import("./b").ns.y`) are exports of the imported module, not references to this file's imports | ||
| if ast.IsPartOfTypeNode(topProp) || isImportTypeQualifierPart(topProp) != nil { |
Contributor
Author
There was a problem hiding this comment.
Per comment in isPartOfTypeNodeInParent:
// Do not recursively call isPartOfTypeNode on the parent. In the example:
// let a: A.B.C;
// Calling isPartOfTypeNode would consider the qualified name A.B a type node.
// Only C and A.B.C are type nodes.So, unfortunately, the import type qualifier parts have to be tested separately here.
Copilot started reviewing on behalf of
Mateusz Burzyński (Andarist)
October 5, 2026 10:27
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused checker change correctly distinguishes imported-module qualifiers and is covered by diagnostic and emit regressions.
Review effort: Balanced
Findings: None
What changed in this PR
Prevents emit-time alias tracking from misinterpreting typeof import() qualifiers as local imports, avoiding flaky diagnostics and incorrect import retention.
Changes:
- Skip linked-reference marking for import-type qualifiers.
- Add regression tests for diagnostics and import elision.
- Add corresponding compiler baselines.
| File | Description |
|---|---|
tsc/internal/checker/checker.go |
Excludes import-type qualifiers from local alias tracking. |
tsc/testdata/tests/cases/compiler/noFlakyDiagnosticsTypeofImportTypeQualifier1.ts |
Tests unresolved-module diagnostics. |
tsc/testdata/tests/cases/compiler/noFlakyDiagnosticsTypeofImportTypeQualifier2.ts |
Tests missing exported qualifiers. |
tsc/testdata/tests/cases/compiler/importElisionTypeofImportTypeQualifier.ts |
Tests correct import elision. |
tsc/testdata/baselines/reference/compiler/noFlakyDiagnosticsTypeofImportTypeQualifier1.errors.txt |
Records expected diagnostics. |
tsc/testdata/baselines/reference/compiler/noFlakyDiagnosticsTypeofImportTypeQualifier1.js |
Records emitted JavaScript. |
tsc/testdata/baselines/reference/compiler/noFlakyDiagnosticsTypeofImportTypeQualifier1.symbols |
Records symbol resolution. |
tsc/testdata/baselines/reference/compiler/noFlakyDiagnosticsTypeofImportTypeQualifier1.types |
Records inferred types. |
tsc/testdata/baselines/reference/compiler/noFlakyDiagnosticsTypeofImportTypeQualifier2.errors.txt |
Records expected diagnostics. |
tsc/testdata/baselines/reference/compiler/noFlakyDiagnosticsTypeofImportTypeQualifier2.js |
Records emitted JavaScript. |
tsc/testdata/baselines/reference/compiler/noFlakyDiagnosticsTypeofImportTypeQualifier2.symbols |
Records symbol resolution. |
tsc/testdata/baselines/reference/compiler/noFlakyDiagnosticsTypeofImportTypeQualifier2.types |
Records inferred types. |
tsc/testdata/baselines/reference/compiler/importElisionTypeofImportTypeQualifier.js |
Confirms the import is elided. |
tsc/testdata/baselines/reference/compiler/importElisionTypeofImportTypeQualifier.symbols |
Confirms qualifier symbol resolution. |
tsc/testdata/baselines/reference/compiler/importElisionTypeofImportTypeQualifier.types |
Confirms resulting types. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the issue reported here: #64623 (comment)