Repository navigation
Prevent nil dereference during package export resolution - #64419
Draft
Daniel Rosenwasser (DanielRosenwasser) with Copilot wants to merge 4 commits into
Draft
Daniel Rosenwasser (DanielRosenwasser) with Copilot wants to merge 4 commits into
Daniel Rosenwasser (DanielRosenwasser) with Copilot wants to merge 4 commits into
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix likely nil pointer dereference during program construction
Prevent nil dereference during package export resolution
Sep 24, 2026
Member
|
Copilot you need a realistic test case that is not just a unit test |
Agent-Logs-Url: https://github.com/microsoft/TypeScript/sessions/19c127c7-891c-4c63-9768-a1600188ea6c Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Copilot stopped work on behalf of
Daniel Rosenwasser (DanielRosenwasser) due to an error
September 24, 2026 22:44
Daniel Rosenwasser (DanielRosenwasser)
requested changes
Sep 28, 2026
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Member
There was a problem hiding this comment.
Copilot can you modify this to a compiler test that is not a simple unit test?
Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Contributor
Author
Addressed in cb5755f. The coverage is now a compiler test using normal package.json exports resolution during program construction; the cache-injection unit test was removed.
Addressed in cb5755f. The synthetic resolver test is replaced with a compiler test that constructs a program from two root files and resolves a real package trailing-slash export mapping. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package exports/imports resolution could dereference a nil lookup table during program construction.