Skip to content

Use string literal types for '[Symbol.toStringTag]' properties #6361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Daniel Rosenwasser (DanielRosenwasser) merged 5 commits into from
Jan 5, 2016
Merged

Use string literal types for '[Symbol.toStringTag]' properties #6361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
347359c
Added '[Symbol.toStringTag]' property to 'GeneratorFunction'.
DanielRosenwasser Jan 5, 2016
a4dc0f3
Added '[Symbol.toStringTag]' properties to type arrays.
DanielRosenwasser Jan 5, 2016
7d292c4
Use string literals for '[Symbol.toStringTag]' properties.
DanielRosenwasser Jan 5, 2016
3fd5fd6
Updated a test and added a new test for assignability betewen typed a…
DanielRosenwasser Jan 5, 2016
5248b2c
Accepted baselines.
DanielRosenwasser Jan 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions src/lib/es6.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ interface Symbol {
/** Returns the primitive value of the specified object. */
valueOf(): Object;

[Symbol.toStringTag]: string;
[Symbol.toStringTag]: "Symbol";
}

interface SymbolConstructor {
Expand Down Expand Up @@ -565,7 +565,7 @@ interface IterableIterator<T> extends Iterator<T> {
}

interface GeneratorFunction extends Function {

[Symbol.toStringTag]: "GeneratorFunction";
}

interface GeneratorFunctionConstructor {
Expand Down Expand Up @@ -690,7 +690,7 @@ interface Math {
*/
cbrt(x: number): number;

[Symbol.toStringTag]: string;
[Symbol.toStringTag]: "Math";
}

interface Date {
Expand Down Expand Up @@ -807,7 +807,7 @@ interface Map<K, V> {
size: number;
values(): IterableIterator<V>;
[Symbol.iterator]():IterableIterator<[K,V]>;
[Symbol.toStringTag]: string;
[Symbol.toStringTag]: "Map";
}

interface MapConstructor {
Expand All @@ -824,7 +824,7 @@ interface WeakMap<K, V> {
get(key: K): V;
has(key: K): boolean;
set(key: K, value?: V): WeakMap<K, V>;
[Symbol.toStringTag]: string;
[Symbol.toStringTag]: "WeakMap";
}

interface WeakMapConstructor {
Expand All @@ -846,7 +846,7 @@ interface Set<T> {
size: number;
values(): IterableIterator<T>;
[Symbol.iterator]():IterableIterator<T>;
[Symbol.toStringTag]: string;
[Symbol.toStringTag]: "Set";
}

interface SetConstructor {
Expand All @@ -862,7 +862,7 @@ interface WeakSet<T> {
clear(): void;
delete(value: T): boolean;
has(value: T): boolean;
[Symbol.toStringTag]: string;
[Symbol.toStringTag]: "WeakSet";
}

interface WeakSetConstructor {
Expand All @@ -874,7 +874,7 @@ interface WeakSetConstructor {
declare var WeakSet: WeakSetConstructor;

interface JSON {
[Symbol.toStringTag]: string;
[Symbol.toStringTag]: "JSON";
}

/**
Expand All @@ -884,11 +884,11 @@ interface JSON {
* buffer as needed.
*/
interface ArrayBuffer {
[Symbol.toStringTag]: string;
[Symbol.toStringTag]: "ArrayBuffer";
}

interface DataView {
[Symbol.toStringTag]: string;
[Symbol.toStringTag]: "DataView";
}

/**
Expand All @@ -909,6 +909,7 @@ interface Int8Array {
*/
values(): IterableIterator<number>;
[Symbol.iterator](): IterableIterator<number>;
[Symbol.toStringTag]: "Int8Array";
}

interface Int8ArrayConstructor {
Expand Down Expand Up @@ -941,6 +942,7 @@ interface Uint8Array {
*/
values(): IterableIterator<number>;
[Symbol.iterator](): IterableIterator<number>;
[Symbol.toStringTag]: "UInt8Array";
}

interface Uint8ArrayConstructor {
Expand Down Expand Up @@ -976,6 +978,7 @@ interface Uint8ClampedArray {
values(): IterableIterator<number>;

[Symbol.iterator](): IterableIterator<number>;
[Symbol.toStringTag]: "Uint8ClampedArray";
}

interface Uint8ClampedArrayConstructor {
Expand Down Expand Up @@ -1013,6 +1016,7 @@ interface Int16Array {


[Symbol.iterator](): IterableIterator<number>;
[Symbol.toStringTag]: "Int16Array";
}

interface Int16ArrayConstructor {
Expand Down Expand Up @@ -1045,6 +1049,7 @@ interface Uint16Array {
*/
values(): IterableIterator<number>;
[Symbol.iterator](): IterableIterator<number>;
[Symbol.toStringTag]: "Uint16Array";
}

interface Uint16ArrayConstructor {
Expand Down Expand Up @@ -1077,6 +1082,7 @@ interface Int32Array {
*/
values(): IterableIterator<number>;
[Symbol.iterator](): IterableIterator<number>;
[Symbol.toStringTag]: "Int32Array";
}

interface Int32ArrayConstructor {
Expand Down Expand Up @@ -1109,6 +1115,7 @@ interface Uint32Array {
*/
values(): IterableIterator<number>;
[Symbol.iterator](): IterableIterator<number>;
[Symbol.toStringTag]: "Uint32Array";
}

interface Uint32ArrayConstructor {
Expand Down Expand Up @@ -1141,6 +1148,7 @@ interface Float32Array {
*/
values(): IterableIterator<number>;
[Symbol.iterator](): IterableIterator<number>;
[Symbol.toStringTag]: "Float32Array";
}

interface Float32ArrayConstructor {
Expand Down Expand Up @@ -1173,6 +1181,7 @@ interface Float64Array {
*/
values(): IterableIterator<number>;
[Symbol.iterator](): IterableIterator<number>;
[Symbol.toStringTag]: "Float64Array";
}

interface Float64ArrayConstructor {
Expand Down Expand Up @@ -1249,7 +1258,7 @@ interface Promise<T> {
catch(onrejected?: (reason: any) => T | PromiseLike<T>): Promise<T>;
catch(onrejected?: (reason: any) => void): Promise<T>;

[Symbol.toStringTag]: string;
[Symbol.toStringTag]: "Promise";
}

interface PromiseConstructor {
Expand Down
5 changes: 0 additions & 5 deletions tests/baselines/reference/typedArrays.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ function CreateIntegerTypedArraysFromArrayLike(obj:ArrayLike<number>) {
return typedArrays;
}

/*
function CreateTypedArraysOf(obj) {
var typedArrays = [];
typedArrays[0] = Int8Array.of(...obj);
Expand All @@ -90,7 +89,6 @@ function CreateTypedArraysOf(obj) {

return typedArrays;
}
*/

function CreateTypedArraysOf2() {
var typedArrays = [];
Expand Down Expand Up @@ -203,7 +201,6 @@ function CreateIntegerTypedArraysFromArrayLike(obj) {
typedArrays[8] = Uint8ClampedArray.from(obj);
return typedArrays;
}
/*
function CreateTypedArraysOf(obj) {
var typedArrays = [];
typedArrays[0] = Int8Array.of(...obj);
Expand All @@ -215,10 +212,8 @@ function CreateTypedArraysOf(obj) {
typedArrays[6] = Float32Array.of(...obj);
typedArrays[7] = Float64Array.of(...obj);
typedArrays[8] = Uint8ClampedArray.of(...obj);

return typedArrays;
}
*/
function CreateTypedArraysOf2() {
var typedArrays = [];
typedArrays[0] = Int8Array.of(1, 2, 3, 4);
Expand Down
Loading