[experiment] trying to short circuit relations in more places by jakebailey · Pull Request #59086 · microsoft/TypeScript

Jake Bailey (jakebailey) · 2024-07-01T00:06:28Z

sorta kinda like #56072

Jake Bailey (jakebailey) · 2024-07-01T00:06:36Z

TypeScript Bot (@typescript-bot) perf test this faster

TypeScript Bot (typescript-bot) · 2024-07-01T00:06:39Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-07-01T00:42:51Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,211k (± 0.09%)}	_{192,845k (± 0.76%)}	_~	_192,169k	_195,810k	_{p=0.054 n=6}
_{Parse Time}	_{1.31s (± 0.75%)}	_{1.30s (± 0.64%)}	_~	_1.29s	_1.31s	_{p=0.445 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.45s (± 0.53%)}	_{9.54s (± 0.58%)}	_{+0.09s (+ 0.99%)}	_9.46s	_9.61s	_{p=0.016 n=6}
_{Emit Time}	_{2.76s (± 0.79%)}	_{2.76s (± 0.72%)}	_~	_2.73s	_2.79s	_{p=0.738 n=6}
_{Total Time}	_{14.22s (± 0.44%)}	_{14.30s (± 0.46%)}	_~	_14.18s	_14.37s	_{p=0.147 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,366k (± 0.01%)}	_{1,218,421k (± 0.00%)}	_~	_1,218,361k	_1,218,475k	_{p=0.128 n=6}
_{Parse Time}	_{6.67s (± 0.52%)}	_{6.65s (± 0.62%)}	_~	_6.59s	_6.71s	_{p=0.571 n=6}
_{Bind Time}	_{1.87s (± 0.56%)}	_{1.86s (± 0.44%)}	_~	_1.85s	_1.87s	_{p=0.865 n=6}
_{Check Time}	_{30.67s (± 0.30%)}	_{30.70s (± 0.27%)}	_~	_30.62s	_30.82s	_{p=0.748 n=6}
_{Emit Time}	_{13.56s (± 0.51%)}	_{13.55s (± 0.26%)}	_~	_13.50s	_13.59s	_{p=0.748 n=6}
_{Total Time}	_{52.76s (± 0.15%)}	_{52.77s (± 0.10%)}	_~	_52.72s	_52.87s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,132,924	_2,132,924	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,423	_926,423	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,115,145k (± 0.00%)}	_{2,115,234k (± 0.00%)}	_~	_2,115,123k	_2,115,389k	_{p=0.128 n=6}
_{Parse Time}	_{6.65s (± 0.22%)}	_{6.65s (± 0.16%)}	_~	_6.64s	_6.67s	_{p=1.000 n=6}
_{Bind Time}	_{2.34s (± 0.22%)}	_{2.34s (± 0.35%)}	_~	_2.33s	_2.35s	_{p=0.929 n=6}
_{Check Time}	_{70.80s (± 0.47%)}	_{70.74s (± 0.46%)}	_~	_70.23s	_71.11s	_{p=0.748 n=6}
_{Emit Time}	_{0.14s (± 2.95%)}	_0.14s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{79.93s (± 0.43%)}	_{79.87s (± 0.41%)}	_~	_79.37s	_80.24s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,260	_1,225,269	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,341	_261,343	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,340,216k (± 0.05%)}	_{2,340,634k (± 0.04%)}	_~	_2,339,229k	_2,341,803k	_{p=0.471 n=6}
_{Parse Time}	_{5.02s (± 0.51%)}	_{5.00s (± 0.54%)}	_~	_4.97s	_5.05s	_{p=0.226 n=6}
_{Bind Time}	_{1.92s (± 1.01%)}	_{1.91s (± 0.77%)}	_~	_1.89s	_1.93s	_{p=0.625 n=6}
_{Check Time}	_{34.14s (± 0.40%)}	_{34.46s (± 0.47%)}	_{+0.32s (+ 0.93%)}	_34.21s	_34.64s	_{p=0.013 n=6}
_{Emit Time}	_{2.60s (± 4.49%)}	_{2.62s (± 5.13%)}	_~	_2.53s	_2.88s	_{p=1.000 n=6}
_{Total Time}	_{43.72s (± 0.52%)}	_{43.99s (± 0.55%)}	_~	_43.63s	_44.31s	_{p=0.093 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,260	_1,225,269	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,341	_261,343	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,416,055k (± 0.04%)}	_{2,416,576k (± 0.05%)}	_~	_2,415,233k	_2,418,085k	_{p=0.575 n=6}
_{Parse Time}	_{7.72s (± 0.61%)}	_{7.71s (± 1.27%)}	_~	_7.58s	_7.85s	_{p=0.575 n=6}
_{Bind Time}	_{2.49s (± 1.12%)}	_{2.52s (± 0.99%)}	_~	_2.49s	_2.55s	_{p=0.172 n=6}
_{Check Time}	_{50.18s (± 0.20%)}	_{50.88s (± 0.88%)}	_{+0.70s (+ 1.39%)}	_50.32s	_51.49s	_{p=0.008 n=6}
_{Emit Time}	_{3.82s (± 2.20%)}	_{3.91s (± 4.19%)}	_~	_3.73s	_4.13s	_{p=0.298 n=6}
_{Total Time}	_{64.23s (± 0.23%)}	_{65.02s (± 1.00%)}	_{+0.78s (+ 1.22%)}	_64.28s	_65.93s	_{p=0.020 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,194	_258,203	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,737	_104,739	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,467k (± 0.02%)}	_{427,563k (± 0.01%)}	_{+95k (+ 0.02%)}	_427,497k	_427,615k	_{p=0.045 n=6}
_{Parse Time}	_{4.07s (± 0.55%)}	_{4.08s (± 0.61%)}	_~	_4.05s	_4.11s	_{p=0.415 n=6}
_{Bind Time}	_{1.62s (± 1.49%)}	_{1.63s (± 1.69%)}	_~	_1.58s	_1.65s	_{p=0.510 n=6}
_{Check Time}	_{21.97s (± 0.33%)}	_{22.26s (± 0.61%)}	_{+0.29s (+ 1.32%)}	_22.12s	_22.49s	_{p=0.005 n=6}
_{Emit Time}	_{1.54s (± 0.68%)}	_{1.55s (± 1.15%)}	_~	_1.53s	_1.58s	_{p=0.805 n=6}
_{Total Time}	_{29.21s (± 0.19%)}	_{29.52s (± 0.39%)}	_{+0.32s (+ 1.08%)}	_29.42s	_29.71s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,521k (± 0.04%)}	_{369,536k (± 0.03%)}	_~	_369,405k	_369,675k	_{p=0.575 n=6}
_{Parse Time}	_{2.76s (± 0.53%)}	_{2.75s (± 1.43%)}	_~	_2.69s	_2.80s	_{p=0.870 n=6}
_{Bind Time}	_{1.58s (± 1.09%)}	_{1.57s (± 0.62%)}	_~	_1.56s	_1.59s	_{p=0.492 n=6}
_{Check Time}	_{15.43s (± 0.22%)}	_{15.60s (± 0.27%)}	_{+0.17s (+ 1.12%)}	_15.53s	_15.64s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.77s (± 0.15%)}	_{19.93s (± 0.36%)}	_{+0.16s (+ 0.80%)}	_19.80s	_20.02s	_{p=0.008 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,879,835	_2,879,835	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,372	_975,372	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,042,586k (± 0.00%)}	_{3,042,660k (± 0.00%)}	_~	_3,042,536k	_3,042,760k	_{p=0.173 n=6}
_{Parse Time}	_{13.67s (± 0.24%)}	_{13.67s (± 0.30%)}	_~	_13.62s	_13.72s	_{p=0.808 n=6}
_{Bind Time}	_{4.24s (± 2.01%)}	_{4.20s (± 0.19%)}	_~	_4.19s	_4.21s	_{p=0.682 n=6}
_{Check Time}	_{74.77s (± 2.14%)}	_{74.04s (± 0.90%)}	_~	_73.59s	_75.33s	_{p=0.423 n=6}
_{Emit Time}	_{23.09s (± 7.16%)}	_{23.71s (± 2.92%)}	_~	_22.54s	_24.43s	_{p=0.936 n=6}
_{Total Time}	_{115.76s (± 0.32%)}	_{115.62s (± 0.21%)}	_~	_115.24s	_115.97s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,647k (± 0.03%)}	_{411,601k (± 0.01%)}	_~	_411,547k	_411,676k	_{p=0.471 n=6}
_{Parse Time}	_{3.83s (± 0.64%)}	_{3.83s (± 0.51%)}	_~	_3.80s	_3.86s	_{p=0.687 n=6}
_{Bind Time}	_{1.70s (± 0.49%)}	_{1.70s (± 0.71%)}	_~	_1.69s	_1.72s	_{p=1.000 n=6}
_{Check Time}	_{16.78s (± 0.32%)}	_{16.77s (± 0.36%)}	_~	_16.68s	_16.85s	_{p=0.808 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.30s (± 0.27%)}	_{22.30s (± 0.27%)}	_~	_22.20s	_22.37s	_{p=0.936 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,947k (± 0.06%)}	_{462,698k (± 0.07%)}	_~	_462,360k	_463,118k	_{p=0.109 n=6}
_{Parse Time}	_{3.16s (± 0.83%)}	_{3.16s (± 0.77%)}	_~	_3.13s	_3.20s	_{p=1.000 n=6}
_{Bind Time}	_{1.17s (± 0.54%)}	_1.17s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{17.91s (± 0.24%)}	_{17.98s (± 0.40%)}	_~	_17.88s	_18.08s	_{p=0.065 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.24s (± 0.18%)}	_{22.32s (± 0.32%)}	_~	_22.21s	_22.41s	_{p=0.077 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Jake Bailey (jakebailey) added 2 commits June 29, 2024 22:51

hacking on short circuit literal relation

bf0b786

isTriviallyRelated

17d02d9

TypeScript Bot (typescript-bot) assigned Jake Bailey (jakebailey) Jul 1, 2024

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 1, 2024

Jake Bailey (jakebailey) closed this Jul 24, 2024

Jake Bailey (jakebailey) deleted the short-circuit-literal-relation branch July 24, 2024 21:37

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Navigation Menu

Repository navigation

[experiment] trying to short circuit relations in more places - #59086

[experiment] trying to short circuit relations in more places#59086
Jake Bailey (jakebailey) wants to merge 2 commits into
microsoft:mainfrom
jakebailey:short-circuit-literal-relation

Jake Bailey (jakebailey) commented Jul 1, 2024

Uh oh!

Jake Bailey (jakebailey) commented Jul 1, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 1, 2024 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 1, 2024

tsc

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Jake Bailey (jakebailey) commented Jul 1, 2024

Uh oh!

Jake Bailey (jakebailey) commented Jul 1, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jul 1, 2024

tsc

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TypeScript Bot (typescript-bot) commented Jul 1, 2024 •

edited

Loading