Add Promise overloads for undefined `then` callback by andrewbranch · Pull Request #58678 · microsoft/TypeScript

Andrew Branch (andrewbranch) · 2024-05-28T15:43:00Z

Fixes #58619, but surely breaks too much other stuff

Andrew Branch (andrewbranch) · 2024-05-28T15:43:13Z

TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) perf test

TypeScript Bot (typescript-bot) · 2024-05-28T15:43:17Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top100`	✅ Started	👀 Results
`perf test`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-05-28T16:22:38Z

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,185	_{+32 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_50,242	_50,274	_{+32 (+ 0.06%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{193,450k (± 0.96%)}	_{192,854k (± 0.75%)}	_~	_192,224k	_195,811k	_{p=0.810 n=6}
_{Parse Time}	_{1.94s (± 1.37%)}	_{1.96s (± 0.99%)}	_~	_1.93s	_1.98s	_{p=0.188 n=6}
_{Bind Time}	_{1.08s (± 0.97%)}	_{1.07s (± 0.78%)}	_~	_1.06s	_1.08s	_{p=0.109 n=6}
_{Check Time}	_{14.00s (± 0.25%)}	_{14.03s (± 0.37%)}	_~	_13.95s	_14.09s	_{p=0.378 n=6}
_{Emit Time}	_{3.91s (± 0.50%)}	_{3.88s (± 0.76%)}	_~	_3.83s	_3.91s	_{p=0.064 n=6}
_{Total Time}	_{20.93s (± 0.29%)}	_{20.94s (± 0.24%)}	_~	_20.88s	_20.99s	_{p=0.688 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,105	_945,166	_{+1,061 (+ 0.11%)}	_~	_~	_{p=0.001 n=6}
_Types	_407,032	_408,080	_{+1,048 (+ 0.26%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,222,072k (± 0.00%)}	_{1,223,023k (± 0.00%)}	_{+951k (+ 0.08%)}	_1,222,989k	_1,223,059k	_{p=0.005 n=6}
_{Parse Time}	_{8.13s (± 0.65%)}	_{8.04s (± 0.45%)}	_{-0.09s (- 1.17%)}	_7.98s	_8.09s	_{p=0.010 n=6}
_{Bind Time}	_{2.24s (± 0.84%)}	_{2.24s (± 0.34%)}	_~	_2.23s	_2.25s	_{p=0.565 n=6}
_{Check Time}	_{36.47s (± 0.38%)}	_{36.60s (± 0.44%)}	_~	_36.41s	_36.81s	_{p=0.173 n=6}
_{Emit Time}	_{17.51s (± 0.29%)}	_{17.47s (± 0.68%)}	_~	_17.36s	_17.69s	_{p=0.336 n=6}
_{Total Time}	_{64.35s (± 0.18%)}	_{64.34s (± 0.23%)}	_~	_64.15s	_64.59s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,983,039	_1,983,113	_{+74 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_881,252	_881,336	_{+84 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,888,198k (± 0.00%)}	_{1,888,201k (± 0.00%)}	_~	_1,888,143k	_1,888,224k	_{p=0.471 n=6}
_{Parse Time}	_{9.91s (± 0.27%)}	_{9.95s (± 0.34%)}	_~	_9.89s	_9.99s	_{p=0.075 n=6}
_{Bind Time}	_{3.34s (± 0.83%)}	_{3.37s (± 0.68%)}	_~	_3.33s	_3.39s	_{p=0.103 n=6}
_{Check Time}	_{87.42s (± 0.26%)}	_{87.62s (± 0.27%)}	_~	_87.28s	_88.01s	_{p=0.230 n=6}
_{Emit Time}	_0.20s	_0.20s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{100.87s (± 0.25%)}	_{101.14s (± 0.24%)}	_~	_100.82s	_101.56s	_{p=0.128 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,317	_1,226,877	_{+560 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,840	_261,079	_{+239 (+ 0.09%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,368,405k (± 2.60%)}	_{2,395,233k (± 3.28%)}	_~	_2,343,984k	_2,497,699k	_{p=0.093 n=6}
_{Parse Time}	_{5.99s (± 0.79%)}	_{5.96s (± 0.91%)}	_~	_5.92s	_6.06s	_{p=0.199 n=6}
_{Bind Time}	_{2.26s (± 1.07%)}	_{2.27s (± 0.82%)}	_~	_2.25s	_2.30s	_{p=0.421 n=6}
_{Check Time}	_{39.92s (± 0.42%)}	_{39.88s (± 0.37%)}	_~	_39.67s	_40.10s	_{p=0.688 n=6}
_{Emit Time}	_{3.10s (± 4.37%)}	_{3.03s (± 2.18%)}	_~	_2.95s	_3.12s	_{p=0.378 n=6}
_{Total Time}	_{51.27s (± 0.63%)}	_{51.15s (± 0.34%)}	_~	_50.95s	_51.44s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,317	_1,226,877	_{+560 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,840	_261,079	_{+239 (+ 0.09%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,494,835k (± 3.32%)}	_{2,470,776k (± 3.17%)}	_~	_2,419,081k	_2,572,648k	_{p=0.810 n=6}
_{Parse Time}	_{7.69s (± 1.11%)}	_{7.66s (± 0.91%)}	_~	_7.56s	_7.74s	_{p=0.378 n=6}
_{Bind Time}	_{2.48s (± 0.74%)}	_{2.49s (± 0.57%)}	_~	_2.47s	_2.51s	_{p=0.515 n=6}
_{Check Time}	_{49.85s (± 0.56%)}	_{49.73s (± 0.14%)}	_~	_49.63s	_49.80s	_{p=0.575 n=6}
_{Emit Time}	_{3.82s (± 3.81%)}	_{3.86s (± 2.78%)}	_~	_3.71s	_4.03s	_{p=0.689 n=6}
_{Total Time}	_{63.86s (± 0.69%)}	_{63.73s (± 0.25%)}	_~	_63.56s	_64.02s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,026	_258,058	_{+32 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,904	_104,904	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,840k (± 0.01%)}	_{426,930k (± 0.01%)}	_{+89k (+ 0.02%)}	_426,873k	_427,005k	_{p=0.045 n=6}
_{Parse Time}	_{4.13s (± 0.68%)}	_{4.14s (± 0.51%)}	_~	_4.12s	_4.18s	_{p=0.085 n=6}
_{Bind Time}	_{1.62s (± 1.72%)}	_{1.63s (± 0.92%)}	_~	_1.62s	_1.66s	_{p=0.293 n=6}
_{Check Time}	_{22.38s (± 0.40%)}	_{22.37s (± 0.47%)}	_~	_22.26s	_22.57s	_{p=0.810 n=6}
_{Emit Time}	_{1.70s (± 2.25%)}	_{1.67s (± 0.85%)}	_~	_1.65s	_1.69s	_{p=0.260 n=6}
_{Total Time}	_{29.82s (± 0.24%)}	_{29.82s (± 0.34%)}	_~	_29.73s	_30.01s	_{p=0.629 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,597	_{+32 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,794k (± 0.03%)}	_{369,899k (± 0.02%)}	_~	_369,786k	_369,982k	_{p=0.128 n=6}
_{Parse Time}	_{3.50s (± 0.56%)}	_{3.52s (± 0.94%)}	_~	_3.47s	_3.56s	_{p=0.295 n=6}
_{Bind Time}	_{1.93s (± 0.78%)}	_{1.94s (± 1.07%)}	_~	_1.90s	_1.96s	_{p=0.739 n=6}
_{Check Time}	_{19.36s (± 0.36%)}	_{19.31s (± 0.31%)}	_~	_19.22s	_19.39s	_{p=0.228 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.80s (± 0.27%)}	_{24.76s (± 0.27%)}	_~	_24.69s	_24.85s	_{p=0.421 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₈	_{🔻+8 (+ ∞%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_2,840,561	_2,848,298	_{+7,737 (+ 0.27%)}	_~	_~	_{p=0.001 n=6}
_Types	_962,643	_970,628	_{+7,985 (+ 0.83%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,013,602k (± 0.00%)}	_{3,020,856k (± 0.00%)}	_{+7,254k (+ 0.24%)}	_3,020,811k	_3,020,991k	_{p=0.005 n=6}
_{Parse Time}	_{11.54s (± 0.29%)}	_{11.58s (± 0.20%)}	_{+0.04s (+ 0.32%)}	_11.55s	_11.61s	_{p=0.043 n=6}
_{Bind Time}	_{3.59s (± 2.64%)}	_{3.65s (± 0.14%)}	_~	_3.65s	_3.66s	_{p=0.352 n=6}
_{Check Time}	_{63.96s (± 2.33%)}	_{63.51s (± 0.25%)}	_~	_63.27s	_63.67s	_{p=0.470 n=6}
_{Emit Time}	_{19.56s (± 6.90%)}	_{20.08s (± 0.34%)}	_~	_19.95s	_20.14s	_{p=0.936 n=6}
_{Total Time}	_{98.65s (± 0.13%)}	_{98.82s (± 0.14%)}	_~	_98.68s	_98.98s	_{p=0.054 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,048	_266,388	_{+340 (+ 0.13%)}	_~	_~	_{p=0.001 n=6}
_Types	_108,470	_108,861	_{+391 (+ 0.36%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{410,805k (± 0.01%)}	_{411,156k (± 0.01%)}	_{+351k (+ 0.09%)}	_411,094k	_411,222k	_{p=0.005 n=6}
_{Parse Time}	_{3.83s (± 0.51%)}	_{3.85s (± 0.89%)}	_~	_3.80s	_3.90s	_{p=0.225 n=6}
_{Bind Time}	_{1.66s (± 0.76%)}	_{1.66s (± 0.82%)}	_~	_1.65s	_1.69s	_{p=0.924 n=6}
_{Check Time}	_{16.97s (± 0.19%)}	_{16.94s (± 0.21%)}	_~	_16.92s	_17.01s	_{p=0.157 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.46s (± 0.23%)}	_{22.45s (± 0.23%)}	_~	_22.40s	_22.54s	_{p=1.000 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₂	_{🔻+2 (+ ∞%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_535,743	_536,023	_{+280 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_182,738	_183,144	_{+406 (+ 0.22%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{470,459k (± 0.01%)}	_{470,791k (± 0.01%)}	_{+332k (+ 0.07%)}	_470,726k	_470,889k	_{p=0.005 n=6}
_{Parse Time}	_{2.65s (± 0.46%)}	_{2.65s (± 0.48%)}	_~	_2.63s	_2.67s	_{p=0.599 n=6}
_{Bind Time}	_{1.00s (± 0.55%)}	_{1.00s (± 0.41%)}	_~	_1.00s	_1.01s	_{p=0.054 n=6}
_{Check Time}	_{15.59s (± 0.36%)}	_{15.53s (± 0.26%)}	_~	_15.48s	_15.58s	_{p=0.120 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.23s (± 0.32%)}	_{19.18s (± 0.23%)}	_~	_19.12s	_19.22s	_{p=0.142 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,764ms (± 0.77%)}	_{2,986ms (±11.28%)}	_~	_2,746ms	_3,431ms	_{p=0.336 n=6}
_{Req 2 - geterr}	_{6,832ms (±10.61%)}	_{6,792ms (±10.02%)}	_~	_6,167ms	_7,418ms	_{p=0.689 n=6}
_{Req 3 - references}	_{404ms (±10.62%)}	_{362ms (± 9.20%)}	_~	_342ms	_429ms	_{p=0.065 n=6}
_{Req 4 - navto}	_{331ms (± 7.48%)}	_{298ms (± 8.95%)}	_~	_279ms	_340ms	_{p=0.051 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{115ms (± 0.35%)}	_{105ms (± 7.87%)}	_{🟩-10ms (- 8.68%)}	_93ms	_114ms	_{p=0.004 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,937ms (± 1.01%)}	_{2,941ms (± 0.73%)}	_~	_2,913ms	_2,963ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{5,163ms (±11.77%)}	_{4,801ms (± 9.39%)}	_~	_4,606ms	_5,722ms	_{p=0.575 n=6}
_{Req 3 - references}	_{393ms (±10.40%)}	_{406ms (±10.80%)}	_~	_359ms	_449ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{310ms (±10.54%)}	_{311ms (±11.36%)}	_~	_278ms	_352ms	_{p=0.935 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{108ms (± 8.29%)}	_{103ms (±13.04%)}	_~	_88ms	_124ms	_{p=0.419 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{7,637ms (± 0.45%)}	_{7,665ms (± 0.66%)}	_~	_7,612ms	_7,761ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{1,678ms (± 0.54%)}	_{1,694ms (± 0.98%)}	_~	_1,670ms	_1,713ms	_{p=0.064 n=6}
_{Req 3 - references}	_{130ms (± 2.20%)}	_{131ms (± 2.97%)}	_~	_128ms	_138ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{591ms (± 1.50%)}	_{593ms (± 2.03%)}	_~	_579ms	_615ms	_{p=0.810 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,252ms (± 1.99%)}	_{1,258ms (± 1.75%)}	_~	_1,225ms	_1,286ms	_{p=0.688 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.01ms (± 0.17%)}	_{229.12ms (± 0.15%)}	_{+0.12ms (+ 0.05%)}	_226.96ms	_232.80ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{296.80ms (± 0.27%)}	_{296.63ms (± 0.26%)}	_{-0.17ms (- 0.06%)}	_290.05ms	_301.84ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{236.87ms (± 0.14%)}	_{236.85ms (± 0.16%)}	_~	_235.22ms	_242.45ms	_{p=0.237 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{287.85ms (± 0.28%)}	_{287.68ms (± 0.29%)}	_{-0.17ms (- 0.06%)}	_280.74ms	_294.40ms	_{p=0.003 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-05-28T17:13:27Z

Andrew Branch (@andrewbranch) Here are the results of running the top 400 repos comparing main and refs/pull/58678/merge:

Something interesting changed - please have a look.

Details

conwnet/github1s

extensions/github1s/tsconfig.json

error TS2769: No overload matches this call.

drizzle-team/drizzle-orm

19 of 25 projects failed to build with the old tsc and were ignored

drizzle-orm/tsconfig.json

error TS2322: Type 'Promise<T | TResult1 | TResult2>' is not assignable to type 'Promise<TResult1 | TResult2>'.
- drizzle-orm/src/query-promise.ts#L31

drizzle-orm/tsconfig.dts.json

error TS2322: Type 'Promise<T | TResult1 | TResult2>' is not assignable to type 'Promise<TResult1 | TResult2>'.
- drizzle-orm/src/query-promise.ts#L31

drizzle-orm/tests/tsconfig.json

error TS2322: Type 'Promise<T | TResult1 | TResult2>' is not assignable to type 'Promise<TResult1 | TResult2>'.
- drizzle-orm/src/query-promise.ts#L31

facebook/flipper

5 of 8 projects failed to build with the old tsc and were ignored

js/js-flipper/tsconfig.json

error TS2349: This expression is not callable.
- js/js-flipper/src/connection.ts#L61

feathersjs/feathers

19 of 27 projects failed to build with the old tsc and were ignored

packages/generators/tsconfig.json

error TS2339: Property 'language' does not exist on type 'PinionContext'.
- packages/generators/src/app/index.ts#L62
- packages/generators/src/authentication/templates/declarations.tpl.ts#L30
- packages/generators/src/authentication/templates/declarations.tpl.ts#L38
- packages/generators/src/service/index.ts#L95
error TS2339: Property 'name' does not exist on type 'PinionContext'.
- packages/generators/src/app/index.ts#L71
- packages/generators/src/service/index.ts#L95
error TS2339: Property 'dependencyVersions' does not exist on type 'PinionContext'.
- packages/generators/src/app/index.ts#L75
error TS2339: Property 'description' does not exist on type 'PinionContext'.
- packages/generators/src/app/index.ts#L85
error TS2339: Property 'framework' does not exist on type 'PinionContext'.
- packages/generators/src/app/index.ts#L91
error TS2339: Property 'transports' does not exist on type 'PinionContext'.
- packages/generators/src/app/index.ts#L101
error TS2339: Property 'packager' does not exist on type 'PinionContext'.
- packages/generators/src/app/index.ts#L111
error TS2339: Property 'client' does not exist on type 'PinionContext'.
- packages/generators/src/app/index.ts#L122
error TS2339: Property 'schema' does not exist on type 'PinionContext'.
- packages/generators/src/app/index.ts#L129
- packages/generators/src/service/index.ts#L95
error TS2345: Argument of type 'PinionContext' is not assignable to parameter of type 'ConnectionGeneratorArguments'.
- packages/generators/src/app/index.ts#L140
- packages/generators/src/app/index.ts#L147
error TS2769: No overload matches this call.
- packages/generators/src/app/index.ts#L145
- packages/generators/src/app/index.ts#L155
- packages/generators/src/app/index.ts#L194
- packages/generators/src/app/templates/configuration.tpl.ts#L81
- packages/generators/src/authentication/index.ts#L30
- packages/generators/src/authentication/index.ts#L32
- packages/generators/src/connection/index.ts#L85
- packages/generators/src/connection/index.ts#L86
- packages/generators/src/hook/index.ts#L20
- packages/generators/src/hook/index.ts#L22
- packages/generators/src/service/index.ts#L93
error TS2339: Property 'transports' does not exist on type 'PinionContext & { language: "ts" | "js"; }'.
- packages/generators/src/app/index.ts#L156
error TS2339: Property 'framework' does not exist on type 'PinionContext & { language: "ts" | "js"; }'.
- packages/generators/src/app/index.ts#L156
error TS2339: Property 'dependencyVersions' does not exist on type 'PinionContext & { language: "ts" | "js"; }'.
- packages/generators/src/app/index.ts#L156
- packages/generators/src/app/index.ts#L195
error TS2339: Property 'dependencies' does not exist on type 'PinionContext & { language: "ts" | "js"; }'.
- packages/generators/src/app/index.ts#L156
error TS2339: Property 'schema' does not exist on type 'PinionContext & { language: "ts" | "js"; }'.
- packages/generators/src/app/index.ts#L156
error TS2339: Property 'packager' does not exist on type 'PinionContext & { language: "ts" | "js"; }'.
- packages/generators/src/app/index.ts#L190
- packages/generators/src/app/index.ts#L213
error TS2339: Property 'devDependencies' does not exist on type 'PinionContext & { language: "ts" | "js"; }'.
- packages/generators/src/app/index.ts#L195
error TS2345: Argument of type '{ name: any; isEntityService: true; lib: any; test: any; language: any; feathers: any; cwd: string; argv: string[]; pinion: Configuration; dependencyVersions: { '@feathersjs/cli': any; }; }' is not assignable to parameter of type 'ServiceGeneratorArguments'.
- packages/generators/src/authentication/index.ts#L84
error TS2339: Property 'service' does not exist on type '{ lib: any; test: any; language: any; feathers: any; cwd: string; argv: string[]; pinion: Configuration; dependencyVersions: { '@feathersjs/cli': any; }; }'.
- packages/generators/src/authentication/index.ts#L86
- packages/generators/src/authentication/index.ts#L92
error TS2345: Argument of type '(ctx: AuthenticationGeneratorContext) => Promise<AuthenticationGeneratorContext>' is not assignable to parameter of type '(ctx: PinionContext) => Promise<PinionContext>'.
- packages/generators/src/authentication/templates/declarations.tpl.ts#L31
- packages/generators/src/authentication/templates/declarations.tpl.ts#L38
error TS2339: Property 'pkg' does not exist on type 'PinionContext & { dependencyVersions: { '@feathersjs/cli': any; }; }'.
- packages/generators/src/commons.ts#L135
- packages/generators/src/commons.ts#L136
- packages/generators/src/commons.ts#L137
- packages/generators/src/commons.ts#L138
error TS2339: Property 'language' does not exist on type 'PinionContext & { dependencyVersions: { '@feathersjs/cli': any; }; }'.
- packages/generators/src/commons.ts#L137
error TS2352: Conversion of type '{ lib: any; test: any; language: any; feathers: any; cwd: string; argv: string[]; pinion: Configuration; dependencyVersions: { '@feathersjs/cli': any; }; }' to type 'ConnectionGeneratorContext' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- packages/generators/src/connection/index.ts#L87
error TS2339: Property 'name' does not exist on type '{ lib: any; test: any; language: any; feathers: any; cwd: string; argv: string[]; pinion: Configuration; dependencyVersions: { '@feathersjs/cli': any; }; }'.
- packages/generators/src/hook/index.ts#L42
error TS2339: Property 'path' does not exist on type 'PinionContext'.
- packages/generators/src/service/index.ts#L95
error TS2339: Property 'type' does not exist on type 'PinionContext'.
- packages/generators/src/service/index.ts#L95
error TS2339: Property 'authentication' does not exist on type 'PinionContext'.
- packages/generators/src/service/index.ts#L95
error TS2339: Property 'isEntityService' does not exist on type 'PinionContext'.
- packages/generators/src/service/index.ts#L95
error TS2339: Property 'feathers' does not exist on type 'PinionContext'.
- packages/generators/src/service/index.ts#L95
error TS2339: Property 'lib' does not exist on type 'PinionContext'.
- packages/generators/src/service/index.ts#L95

gcanti/fp-ts

4 of 5 projects failed to build with the old tsc and were ignored

tsconfig.build-es6.json

error TS2322: Type 'A' is not assignable to type 'Promise<Either<E, [ReadonlyNonEmptyArray, S]>>'.
- src/StateReaderTaskEither.ts#L1458
error TS2345: Argument of type 'Promise<Right<unknown> | Left<E> | Right<[NonEmptyArray, S]>>' is not assignable to parameter of type 'Promise<Either<E, [NonEmptyArray, S]>>'.
- src/StateReaderTaskEither.ts#L1476
error TS2345: Argument of type '([b, s]: [any, any]) => any[]' is not assignable to parameter of type '(a: unknown) => any[]'.
- src/StateReaderTaskEither.ts#L1476
error TS2322: Type 'A' is not assignable to type 'Promise<Either<E, ReadonlyNonEmptyArray>>'.
- src/TaskEither.ts#L1628
error TS2345: Argument of type 'Promise<Left<E> | Right<NonEmptyArray> | Right<NonEmptyArray<unknown>>>' is not assignable to parameter of type 'Promise<Either<E, NonEmptyArray>>'.
- src/TaskEither.ts#L1641
error TS2322: Type 'A' is not assignable to type 'Promise<These<E, ReadonlyNonEmptyArray>>'.
- src/TaskThese.ts#L499
error TS2345: Argument of type 'Promise<Right<NonEmptyArray<unknown>> | Left<E> | Right<NonEmptyArray> | Both<E, NonEmptyArray> | Both<...>>' is not assignable to parameter of type 'Promise<These<E, NonEmptyArray>>'.
- src/TaskThese.ts#L517

graphile/crystal

5 of 10 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2349: This expression is not callable.
error TS7006: Parameter 'data' implicitly has an 'any' type.
- grafast/grafast/src/steps/graphqlResolver.ts#L59 in grafast/grafast/tsconfig.json
- grafast/grafast/src/steps/graphqlResolver.ts#L369 in grafast/grafast/tsconfig.json
error TS7006: Parameter 'results' implicitly has an 'any' type.
- grafast/grafast/src/engine/executeBucket.ts#L112 in grafast/grafast/tsconfig.json
error TS7006: Parameter 'r' implicitly has an 'any' type.
- grafast/grafast/src/engine/executeBucket.ts#L949 in grafast/grafast/tsconfig.json
error TS7006: Parameter 'error' implicitly has an 'any' type.
- grafast/grafast/src/engine/executeBucket.ts#L1073 in grafast/grafast/tsconfig.json
error TS7006: Parameter 'e' implicitly has an 'any' type.
error TS7006: Parameter 'v' implicitly has an 'any' type.
- grafast/grafast/src/prepare.ts#L693 in grafast/grafast/tsconfig.json
error TS7006: Parameter 'result' implicitly has an 'any' type.
- grafast/grafast/src/args.ts#L74 in grafast/grafast/tsconfig.json
error TS2307: Cannot find module 'grafast' or its corresponding type declarations.
- grafast/ruru-components/src/hooks/useFetcher.ts#L12 in grafast/ruru-components/tsconfig.json
error TS2307: Cannot find module 'grafast/mermaid' or its corresponding type declarations.

grafast/ruru/tsconfig.json

error TS2307: Cannot find module 'ruru/server' or its corresponding type declarations.
- grafast/ruru/graphile.config.ts#L3 in grafast/ruru/tsconfig.json

invoke-ai/InvokeAI

invokeai/frontend/web/tsconfig.json

error TS2349: This expression is not callable.
- invokeai/frontend/web/src/features/metadata/util/handlers.ts#L452
error TS7006: Parameter 'value' implicitly has an 'any' type.
- invokeai/frontend/web/src/features/metadata/util/handlers.ts#L452

ionic-team/capacitor

1 of 3 projects failed to build with the old tsc and were ignored

cli/tsconfig.json

error TS2322: Type 'Promise<T | TResult1 | TResult2>' is not assignable to type 'Promise<TResult1 | TResult2>'.
- cli/src/util/promise.ts#L41

ionic-team/ionic-framework

19 of 20 projects failed to build with the old tsc and were ignored

core/tsconfig.json

error TS2322: Type 'Promise<unknown>' is not assignable to type 'Promise<T>'.
- core/src/utils/overlays.ts#L114

jhipster/generator-jhipster

tsconfig.types.json

error TS2322: Type 'Promise<void | BaseGenerator[]>' is not assignable to type 'void | Promise<void>'.
- generators/base-core/generator.ts#L210

tsconfig.spec.json

error TS2322: Type 'Promise<void | BaseGenerator[]>' is not assignable to type 'void | Promise<void>'.
- generators/base-core/generator.ts#L210

tsconfig.json

error TS2322: Type 'Promise<void | BaseGenerator[]>' is not assignable to type 'void | Promise<void>'.
- generators/base-core/generator.ts#L210

jupyterlab/jupyterlab

45 of 58 projects failed to build with the old tsc and were ignored

packages/ui-components/examples/simple-windowed-list/tsconfig.json

error TS2322: Type 'Promise<ICheckpointModel | undefined>' is not assignable to type 'Promise<undefined>'.
- packages/docregistry/src/context.ts#L791 in packages/docregistry/tsconfig.json
- packages/docregistry/src/context.ts#L793 in packages/docregistry/tsconfig.json

examples/filebrowser/src/tsconfig.json

error TS2307: Cannot find module '@jupyterlab/docmanager' or its corresponding type declarations.
- examples/filebrowser/src/index.ts#L27 in examples/filebrowser/src/tsconfig.json
error TS2307: Cannot find module '@jupyterlab/docregistry' or its corresponding type declarations.
- examples/filebrowser/src/index.ts#L29 in examples/filebrowser/src/tsconfig.json
error TS2307: Cannot find module '@jupyterlab/filebrowser' or its corresponding type declarations.
- examples/filebrowser/src/index.ts#L31 in examples/filebrowser/src/tsconfig.json
error TS2307: Cannot find module '@jupyterlab/fileeditor' or its corresponding type declarations.
- examples/filebrowser/src/index.ts#L33 in examples/filebrowser/src/tsconfig.json
error TS7006: Parameter 'model' implicitly has an 'any' type.
- examples/filebrowser/src/index.ts#L154 in examples/filebrowser/src/tsconfig.json

examples/console/src/tsconfig.json

error TS2307: Cannot find module '@jupyterlab/console' or its corresponding type declarations.
- examples/console/src/index.ts#L28 in examples/console/src/tsconfig.json

mattermost/mattermost

1 of 4 projects failed to build with the old tsc and were ignored

e2e-tests/cypress/tsconfig.json

error TS2322: Type 'Chainable<JQuery<any>> | Chainable<{ user: UserProfile; }>' is not assignable to type 'Channel'.
- e2e-tests/cypress/tests/integration/channels/enterprise/guest_accounts/guest_add_spec.ts#L62
- e2e-tests/cypress/tests/integration/channels/enterprise/profile_popover/profile_popover_spec.ts#L100

microsoft/vscode

4 of 54 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2322: Type 'Promise<T | TResult1 | TResult2>' is not assignable to type 'Promise<TResult1 | TResult2>'.
- src/vs/base/common/async.ts#L50
error TS2322: Type 'Promise<LocationLink | LocationLink[] | null | undefined>' is not assignable to type 'Promise<LocationLink | LocationLink[] | undefined>'.
- src/vs/editor/contrib/gotoSymbol/browser/goToSymbol.ts#L42
error TS2345: Argument of type '(() => Promise<Map<URI, DocumentHighlight[]> | null | undefined>)[]' is not assignable to parameter of type 'ITask<Promise<ResourceMap<DocumentHighlight[]> | null | undefined>>[]'.
- src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts#L66
error TS2322: Type 'Promise<unknown>' is not assignable to type 'Promise<T>'.
- src/vs/platform/userDataSync/common/userDataSyncServiceIpc.ts#L158
error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
- src/vs/workbench/api/common/extHostExtensionService.ts#L400
error TS2322: Type 'Promise<Response | R | undefined>' is not assignable to type 'Promise<R | undefined>'.
- src/vs/workbench/contrib/debug/browser/rawDebugSession.ts#L754
error TS2322: Type 'Promise<void | IPagedModel<IExtension>>' is not assignable to type 'Promise<void>'.
- src/vs/workbench/contrib/extensions/browser/extensionsViews.ts#L1449
error TS2322: Type 'Promise<C | TResult1 | TResult2>' is not assignable to type 'Promise<TResult1 | TResult2>'.
- src/vs/workbench/services/search/node/rawSearchService.ts#L392

src/tsconfig.monaco.json

error TS2322: Type 'Promise<T | TResult1 | TResult2>' is not assignable to type 'Promise<TResult1 | TResult2>'.
- src/vs/base/common/async.ts#L50
error TS2322: Type 'Promise<LocationLink | LocationLink[] | null | undefined>' is not assignable to type 'Promise<LocationLink | LocationLink[] | undefined>'.
- src/vs/editor/contrib/gotoSymbol/browser/goToSymbol.ts#L42
error TS2345: Argument of type '(() => Promise<Map<URI, DocumentHighlight[]> | null | undefined>)[]' is not assignable to parameter of type 'ITask<Promise<ResourceMap<DocumentHighlight[]> | null | undefined>>[]'.
- src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts#L66
error TS2322: Type 'Promise<unknown>' is not assignable to type 'Promise<T>'.
- src/vs/platform/userDataSync/common/userDataSyncServiceIpc.ts#L158

src/tsconfig.json

error TS2322: Type 'Promise<T | TResult1 | TResult2>' is not assignable to type 'Promise<TResult1 | TResult2>'.
- src/vs/base/common/async.ts#L50
error TS2322: Type 'Promise<LocationLink | LocationLink[] | null | undefined>' is not assignable to type 'Promise<LocationLink | LocationLink[] | undefined>'.
- src/vs/editor/contrib/gotoSymbol/browser/goToSymbol.ts#L42
error TS2345: Argument of type '(() => Promise<Map<URI, DocumentHighlight[]> | null | undefined>)[]' is not assignable to parameter of type 'ITask<Promise<ResourceMap<DocumentHighlight[]> | null | undefined>>[]'.
- src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts#L66
error TS2322: Type 'Promise<unknown>' is not assignable to type 'Promise<T>'.
- src/vs/platform/userDataSync/common/userDataSyncServiceIpc.ts#L158
error TS2322: Type 'Promise<void | undefined>' is not assignable to type 'Promise<undefined>'.
- src/vs/workbench/api/common/extHostExtensionService.ts#L400
error TS2322: Type 'Promise<Response | R | undefined>' is not assignable to type 'Promise<R | undefined>'.
- src/vs/workbench/contrib/debug/browser/rawDebugSession.ts#L754
error TS2322: Type 'Promise<void | IPagedModel<IExtension>>' is not assignable to type 'Promise<void>'.
- src/vs/workbench/contrib/extensions/browser/extensionsViews.ts#L1449
error TS2322: Type 'Promise<C | TResult1 | TResult2>' is not assignable to type 'Promise<TResult1 | TResult2>'.
- src/vs/workbench/services/search/node/rawSearchService.ts#L392

neoclide/coc.nvim

tsconfig.json

error TS2322: Type 'Promise<void[]>' is not assignable to type 'Promise<void>'.
- src/language-client/textSynchronization.ts#L256

tiangolo/full-stack-fastapi-template

frontend/tsconfig.json

error TS2322: Type 'Promise<T | TResult1 | TResult2>' is not assignable to type 'Promise<TResult1 | TResult2>'.
- frontend/src/client/core/CancelablePromise.ts#L91

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2349: This expression is not callable.
- cli/index.ts#L265 in tsconfig.json
error TS7006: Parameter 'err' implicitly has an 'any' type.
- cli/index.ts#L266 in tsconfig.json

Add Promise overloads for undefined then callback

971281c

Andrew Branch (andrewbranch) mentioned this pull request May 28, 2024

Compiler cannot handle promise.then(null | undefined) #58619

Open

Andrew Branch (andrewbranch) closed this May 28, 2024

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Conversation

Andrew Branch (andrewbranch) commented May 28, 2024

Uh oh!

Andrew Branch (andrewbranch) commented May 28, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 28, 2024

tsc

tsserver

startup

Uh oh!

TypeScript Bot (typescript-bot) commented May 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TypeScript Bot (typescript-bot) commented May 28, 2024 •

edited

Loading