Repository navigation
fix: no longer emit error for functions has no return statement under isolatedDeclarations - #58331
Closed
Jack Works (Jack-Works) wants to merge 1 commit into
Closed
Jack Works (Jack-Works) wants to merge 1 commit into
Jack Works (Jack-Works) wants to merge 1 commit into
Conversation
… isolatedDeclarations
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
Jake Bailey (jakebailey)
requested changes
Apr 26, 2024
Jake Bailey (jakebailey)
left a comment
Jake Bailey (jakebailey)
left a comment
Member
There was a problem hiding this comment.
See: #58330 (comment)
Member
|
#58330 was declined to give us the option to make function declarations and function expressions consistent in the future; going to close this one. Thanks for sending it, though. |
Contributor
|
The TypeScript team hasn't accepted the linked issue #58330. If you can get it accepted, this PR will have a better chance of being reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58330