Repository navigation
[ID-Prep] PR5 - Preserve type nodes from function like expression in declaration emit - #57678
Closed
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 9 commits into
Conversation
…eclrations-from-assertions
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
…d arrow functions.
Titian Cernicova-Dragomir (dragomirtitian)
force-pushed
the
ts-verbatim-declrations-from-function-expressions
branch
from
March 7, 2024 15:00
c8462ed to
cd7636d
Compare
| return { accessibility: SymbolAccessibility.Accessible }; | ||
| } | ||
|
|
||
| // Parameters or binding elements from parameters are always visible in their enclosing function declarations |
Contributor
Author
There was a problem hiding this comment.
The checker complained about the parameter name not being accessible (since arrow functions are not themselves marked as visible by determineIfDeclarationIsVisible.
|
|
||
| function isExpandoFunctionDeclaration(node: Declaration): boolean { | ||
| const declaration = getParseTreeNode(node, isFunctionDeclaration); | ||
| function isExpandoFunctionDeclaration(node: FunctionDeclaration | VariableDeclaration): boolean { |
Contributor
Author
There was a problem hiding this comment.
Both function and variable declarations will now be tested. We can't reliably determine the type for an expando functions variable from just it's declaration so we fall back on the type checker.
Titian Cernicova-Dragomir (dragomirtitian)
changed the title
Titian Cernicova-Dragomir (dragomirtitian)
changed the title
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57677