Skip to content

Make type guards continue to narrow within classes/nested function declarations - #5626

Merged
Wesley Wigham (weswigham) merged 4 commits into
microsoft:masterfrom
weswigham:type-guard-narrowing
Nov 19, 2015
Merged

Wesley Wigham (weswigham) merged 4 commits into
microsoft:masterfrom
weswigham:type-guard-narrowing

Conversation

@weswigham

Copy link
Copy Markdown
Member

Fixes #5619.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this assertion from a comment to

let str: string
:
:
str = x;

@mhegazy

Copy link
Copy Markdown
Contributor

👍

@sandersn

Copy link
Copy Markdown
Member

Sorry, I thought I signed off earlier. :1+:

Wesley Wigham (weswigham) added a commit that referenced this pull request Nov 19, 2015
Make type guards continue to narrow within classes/nested function declarations
@weswigham
Wesley Wigham (weswigham) merged commit b1c8245 into microsoft:master Nov 19, 2015
@weswigham
Wesley Wigham (weswigham) deleted the type-guard-narrowing branch August 17, 2017 23:04
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants