Fix `isGenericReducibleType` to allow HKT technique to function again by ahejlsberg · Pull Request #54112 · microsoft/TypeScript

Anders Hejlsberg (ahejlsberg) · 2023-05-03T15:39:59Z

Anders Hejlsberg (ahejlsberg) · 2023-05-03T15:41:07Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test faster
TypeScript Bot (@typescript-bot) test top100

TypeScript Bot (typescript-bot) · 2023-05-03T15:41:11Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the abridged perf test suite on this PR at dd88229. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-05-03T15:41:11Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based user code test suite on this PR at dd88229. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-05-03T15:41:11Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at dd88229. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-05-03T15:41:11Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based top-repos suite on this PR at dd88229. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-05-03T15:41:11Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at dd88229. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-05-03T15:56:49Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54112

_Metric	_main	₅₄₁₁₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,264k (± 0.01%)}	_{365,259k (± 0.01%)}	_~	_365,229k	_365,318k	_{p=0.688 n=6}
_{Parse Time}	_{3.53s (± 0.77%)}	_{3.55s (± 0.56%)}	_~	_3.52s	_3.58s	_{p=0.224 n=6}
_{Bind Time}	_{1.17s (± 0.44%)}	_{1.17s (± 0.47%)}	_~	_1.17s	_1.18s	_{p=0.640 n=6}
_{Check Time}	_{9.58s (± 0.57%)}	_{9.60s (± 0.44%)}	_~	_9.52s	_9.63s	_{p=0.747 n=6}
_{Emit Time}	_{7.92s (± 0.82%)}	_{7.95s (± 0.80%)}	_~	_7.86s	_8.02s	_{p=0.335 n=6}
_{Total Time}	_{22.20s (± 0.55%)}	_{22.28s (± 0.32%)}	_~	_22.18s	_22.38s	_{p=0.199 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,729k (± 0.05%)}	_{192,777k (± 0.03%)}	_~	_192,686k	_192,836k	_{p=0.378 n=6}
_{Parse Time}	_{1.59s (± 0.95%)}	_{1.59s (± 0.34%)}	_~	_1.59s	_1.60s	_{p=0.865 n=6}
_{Bind Time}	_{0.82s (± 0.00%)}	_{0.82s (± 0.63%)}	_~	_0.82s	_0.83s	_{p=0.174 n=6}
_{Check Time}	_{10.30s (± 0.29%)}	_{10.29s (± 0.35%)}	_~	_10.25s	_10.35s	_{p=0.685 n=6}
_{Emit Time}	_{2.99s (± 0.44%)}	_{3.02s (± 0.93%)}	_{+0.04s (+ 1.23%)}	_3.00s	_3.07s	_{p=0.014 n=6}
_{Total Time}	_{15.71s (± 0.25%)}	_{15.74s (± 0.38%)}	_~	_15.68s	_15.84s	_{p=0.331 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,841k (± 0.01%)}	_{345,853k (± 0.01%)}	_~	_345,827k	_345,888k	_{p=1.000 n=6}
_{Parse Time}	_{2.70s (± 0.30%)}	_{2.72s (± 0.39%)}	_~	_2.70s	_2.73s	_{p=0.078 n=6}
_{Bind Time}	_{1.08s (± 1.31%)}	_{1.08s (± 0.38%)}	_~	_1.08s	_1.09s	_{p=0.858 n=6}
_{Check Time}	_{7.86s (± 0.53%)}	_{7.89s (± 0.29%)}	_~	_7.85s	_7.91s	_{p=0.293 n=6}
_{Emit Time}	_{4.46s (± 0.39%)}	_{4.47s (± 0.61%)}	_~	_4.45s	_4.51s	_{p=0.624 n=6}
_{Total Time}	_{16.11s (± 0.33%)}	_{16.16s (± 0.32%)}	_~	_16.09s	_16.22s	_{p=0.102 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,127k (± 0.01%)}	_{300,115k (± 0.01%)}	_~	_300,085k	_300,132k	_{p=0.336 n=6}
_{Parse Time}	_{2.15s (± 0.38%)}	_{2.15s (± 0.42%)}	_~	_2.14s	_2.16s	_{p=0.550 n=6}
_{Bind Time}	_{1.23s (± 0.66%)}	_{1.24s (± 0.94%)}	_~	_1.22s	_1.25s	_{p=0.401 n=6}
_{Check Time}	_{7.29s (± 0.46%)}	_{7.29s (± 0.75%)}	_~	_7.22s	_7.36s	_{p=0.688 n=6}
_{Emit Time}	_{4.38s (± 0.55%)}	_{4.37s (± 1.01%)}	_~	_4.32s	_4.45s	_{p=0.250 n=6}
_{Total Time}	_{15.05s (± 0.36%)}	_{15.05s (± 0.58%)}	_~	_14.91s	_15.16s	_{p=1.000 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,585k (± 0.01%)}	_{481,651k (± 0.01%)}	_{+66k (+ 0.01%)}	_481,593k	_481,712k	_{p=0.031 n=6}
_{Parse Time}	_{3.24s (± 0.16%)}	_{3.25s (± 0.23%)}	_{+0.01s (+ 0.36%)}	_3.24s	_3.26s	_{p=0.020 n=6}
_{Bind Time}	_{0.94s (± 0.55%)}	_{0.94s (± 0.87%)}	_~	_0.93s	_0.95s	_{p=0.929 n=6}
_{Check Time}	_{17.93s (± 0.41%)}	_{17.84s (± 0.62%)}	_~	_17.70s	_18.03s	_{p=0.199 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.11s (± 0.36%)}	_{22.03s (± 0.49%)}	_~	_21.89s	_22.21s	_{p=0.298 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,337k (± 0.01%)}	_{560,426k (± 0.02%)}	_~	_560,312k	_560,537k	_{p=0.298 n=6}
_{Parse Time}	_{3.99s (± 0.21%)}	_{3.99s (± 0.33%)}	_~	_3.97s	_4.01s	_{p=0.803 n=6}
_{Bind Time}	_{1.76s (± 0.66%)}	_{1.76s (± 0.59%)}	_~	_1.75s	_1.78s	_{p=0.619 n=6}
_{Check Time}	_{3.06s (± 0.55%)}	_{3.06s (± 0.67%)}	_~	_3.05s	_3.09s	_{p=0.806 n=6}
_{Emit Time}	_{0.09s (± 4.45%)}	_{0.09s (± 4.62%)}	_~	_0.08s	_0.09s	_{p=0.218 n=6}
_{Total Time}	_{8.90s (± 0.17%)}	_{8.91s (± 0.24%)}	_~	_8.89s	_8.94s	_{p=0.368 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₁₁₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

TypeScript Bot (typescript-bot) · 2023-05-03T16:10:05Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user test suite comparing main and refs/pull/54112/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Everything looks good!

Jake Bailey (jakebailey) · 2023-05-03T16:29:52Z

TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2023-05-03T16:29:55Z

Heya Jake Bailey (@jakebailey), I've started to run the tarball bundle task on this PR at dd88229. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-05-03T16:31:33Z

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/153735/artifacts?artifactName=tgz&fileId=86B63ABAABD7BD283E61F4D0A8D4ABF9480EC038270693BC271390E9F9FBE3A202&fileName=/typescript-5.1.0-insiders.20230503.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-54112-10".;

TypeScript Bot (typescript-bot) · 2023-05-03T17:20:09Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top-repos suite comparing main and refs/pull/54112/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-05-03T17:53:09Z

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

ecyrbe · 2023-05-03T19:33:51Z

Anders Hejlsberg (@ahejlsberg) nice, i confirm that zodios use case is working again : link to playground

Michael Arnaldi (mikearnaldi) · 2023-05-03T20:01:04Z

Amazing thank you!

Michael Arnaldi (mikearnaldi) · 2023-05-03T20:11:49Z

It seems that it is only partially resolved though, while inference work the signature after map(typeClass) is not resolved, that will make all the inferred types painful to use when the resulting function is not immediately applied.

…ative

Anders Hejlsberg (ahejlsberg) · 2023-05-05T00:07:46Z

Latest commit reverts the changes to type inference and instead fixes the issue by making isGenericReducibleType more conversative. The previous logic would wrongly classify TTypeLambda & { readonly A: A; } as being reducible even though there are no discriminant properties in the type. That's now fixed.

Anders Hejlsberg (ahejlsberg) · 2023-05-05T00:08:18Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test faster
TypeScript Bot (@typescript-bot) test top100

TypeScript Bot (typescript-bot) · 2023-05-05T00:08:21Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the abridged perf test suite on this PR at 64a864b. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-05-05T00:08:21Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 64a864b. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-05-05T00:08:21Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based user code test suite on this PR at 64a864b. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-05-05T00:08:21Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 64a864b. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-05-05T00:08:21Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based top-repos suite on this PR at 64a864b. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-05-05T00:32:17Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user test suite comparing main and refs/pull/54112/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-05-05T02:13:46Z

Hey Anders Hejlsberg (@ahejlsberg), it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

TypeScript Bot (typescript-bot) · 2023-05-05T02:25:59Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top-repos suite comparing main and refs/pull/54112/merge:

Everything looks good!

Jake Bailey (jakebailey) · 2023-05-05T05:27:37Z

TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2023-05-05T05:27:57Z

Heya Jake Bailey (@jakebailey), I've started to run the tarball bundle task on this PR at 64a864b. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-05-05T05:30:08Z

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/153878/artifacts?artifactName=tgz&fileId=7C2445FA53921AB59156ACC7B0E401F443E8B5A75E982249288D1530B8BAD02C02&fileName=/typescript-5.1.0-insiders.20230505.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-54112-28".;

Michael Arnaldi (mikearnaldi) · 2023-05-05T09:49:49Z

Amazing! Looks great

Jake Bailey (jakebailey) · 2023-05-08T21:02:42Z

Wesley Wigham (@weswigham) mentioned that this may break a case where two generic litearl kind props were intersected, but I can't seem to make this case up; can you give an example?

I've tried this to no avail. Playground Link

TypeScript Bot (typescript-bot) · 2023-05-08T21:58:04Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54112

_Metric	_main	₅₄₁₁₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,257k (± 0.01%)}	_{365,263k (± 0.00%)}	_~	_365,246k	_365,290k	_{p=0.378 n=6}
_{Parse Time}	_{3.53s (± 0.58%)}	_{3.56s (± 0.63%)}	_~	_3.54s	_3.60s	_{p=0.052 n=6}
_{Bind Time}	_{1.17s (± 0.44%)}	_{1.17s (± 0.35%)}	_~	_1.17s	_1.18s	_{p=0.595 n=6}
_{Check Time}	_{9.57s (± 0.40%)}	_{9.54s (± 0.29%)}	_~	_9.50s	_9.58s	_{p=0.226 n=6}
_{Emit Time}	_{7.93s (± 0.70%)}	_{7.96s (± 0.69%)}	_~	_7.90s	_8.04s	_{p=0.520 n=6}
_{Total Time}	_{22.21s (± 0.40%)}	_{22.23s (± 0.32%)}	_~	_22.13s	_22.33s	_{p=0.630 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,736k (± 0.01%)}	_{192,776k (± 0.03%)}	_~	_192,686k	_192,854k	_{p=0.298 n=6}
_{Parse Time}	_{1.61s (± 0.55%)}	_{1.59s (± 2.01%)}	_~	_1.53s	_1.62s	_{p=0.273 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.83s (± 0.91%)}	_~	_0.82s	_0.84s	_{p=1.000 n=6}
_{Check Time}	_{10.27s (± 0.31%)}	_{10.30s (± 0.62%)}	_~	_10.23s	_10.40s	_{p=0.372 n=6}
_{Emit Time}	_{3.02s (± 0.84%)}	_{3.02s (± 0.35%)}	_~	_3.00s	_3.03s	_{p=1.000 n=6}
_{Total Time}	_{15.73s (± 0.22%)}	_{15.74s (± 0.40%)}	_~	_15.67s	_15.85s	_{p=1.000 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,858k (± 0.00%)}	_{345,869k (± 0.00%)}	_~	_345,857k	_345,890k	_{p=0.521 n=6}
_{Parse Time}	_{2.74s (± 0.54%)}	_{2.73s (± 0.31%)}	_~	_2.72s	_2.74s	_{p=0.055 n=6}
_{Bind Time}	_{1.09s (± 0.97%)}	_{1.09s (± 0.47%)}	_~	_1.08s	_1.09s	_{p=0.794 n=6}
_{Check Time}	_{7.86s (± 0.38%)}	_{7.87s (± 0.30%)}	_~	_7.84s	_7.89s	_{p=0.684 n=6}
_{Emit Time}	_{4.47s (± 0.73%)}	_{4.47s (± 0.66%)}	_~	_4.43s	_4.50s	_{p=1.000 n=6}
_{Total Time}	_{16.15s (± 0.31%)}	_{16.15s (± 0.32%)}	_~	_16.09s	_16.21s	_{p=0.747 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,100k (± 0.01%)}	_{300,107k (± 0.01%)}	_~	_300,078k	_300,121k	_{p=0.378 n=6}
_{Parse Time}	_{2.17s (± 0.38%)}	_{2.16s (± 0.56%)}	_~	_2.14s	_2.17s	_{p=0.183 n=6}
_{Bind Time}	_{1.23s (± 1.30%)}	_{1.24s (± 0.94%)}	_~	_1.22s	_1.25s	_{p=0.365 n=6}
_{Check Time}	_{7.30s (± 0.59%)}	_{7.29s (± 0.84%)}	_~	_7.22s	_7.38s	_{p=0.471 n=6}
_{Emit Time}	_{4.41s (± 1.83%)}	_{4.37s (± 0.78%)}	_~	_4.33s	_4.43s	_{p=0.244 n=6}
_{Total Time}	_{15.11s (± 0.57%)}	_{15.05s (± 0.64%)}	_~	_14.97s	_15.23s	_{p=0.173 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,578k (± 0.01%)}	_{481,633k (± 0.01%)}	_~	_481,562k	_481,765k	_{p=0.173 n=6}
_{Parse Time}	_{3.25s (± 0.41%)}	_{3.26s (± 0.37%)}	_~	_3.24s	_3.27s	_{p=0.323 n=6}
_{Bind Time}	_{0.94s (± 0.80%)}	_{0.94s (± 0.55%)}	_~	_0.93s	_0.94s	_{p=0.784 n=6}
_{Check Time}	_{17.86s (± 0.67%)}	_{17.91s (± 0.54%)}	_~	_17.76s	_18.06s	_{p=0.630 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.04s (± 0.55%)}	_{22.11s (± 0.50%)}	_~	_21.95s	_22.28s	_{p=0.517 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,387k (± 0.02%)}	_{560,457k (± 0.02%)}	_~	_560,349k	_560,630k	_{p=0.230 n=6}
_{Parse Time}	_{4.00s (± 0.29%)}	_{4.01s (± 0.57%)}	_~	_3.99s	_4.05s	_{p=0.742 n=6}
_{Bind Time}	_{1.76s (± 0.43%)}	_{1.76s (± 0.23%)}	_~	_1.76s	_1.77s	_{p=1.000 n=6}
_{Check Time}	_{3.07s (± 0.67%)}	_{3.06s (± 0.29%)}	_~	_3.05s	_3.07s	_{p=0.215 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.93s (± 0.25%)}	_{8.92s (± 0.35%)}	_~	_8.88s	_8.96s	_{p=0.568 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₁₁₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Jake Bailey (jakebailey) · 2023-05-22T20:09:16Z

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.1

Jake Bailey (jakebailey) · 2023-05-22T20:21:59Z

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.1

... please?

TypeScript Bot (typescript-bot) · 2023-05-22T20:22:02Z

Heya Jake Bailey (@jakebailey), I've started to run the task to cherry-pick this into release-5.1 on this PR at 64a864b. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-05-22T20:29:42Z

Hey Jake Bailey (@jakebailey), I've opened #54349 for you.

Component commits: 33aeffb Improve type inference to allow HKT technique function again dd88229 Add regression test f104b53 Revert changes and instead fix isGenericObjectType to be more conservative 64a864b Accept new baselines

…e-5.1 (#54349) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

Anders Hejlsberg (ahejlsberg) added 2 commits May 3, 2023 08:34

Improve type inference to allow HKT technique function again

33aeffb

Add regression test

dd88229

TypeScript Bot (typescript-bot) assigned Anders Hejlsberg (ahejlsberg) May 3, 2023

TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 3, 2023

Anders Hejlsberg (ahejlsberg) requested review from Ryan Cavanaugh (RyanCavanaugh), Jake Bailey (jakebailey) and Wesley Wigham (weswigham) May 3, 2023 15:40

Wesley Wigham (weswigham) approved these changes May 3, 2023

View reviewed changes

Anders Hejlsberg (ahejlsberg) mentioned this pull request May 4, 2023

Inference is broken on intersection type utilizing polymorphic this #53970

Closed

Anders Hejlsberg (ahejlsberg) added 2 commits May 4, 2023 16:56

Revert changes and instead fix isGenericObjectType to be more conserv…

f104b53

…ative

Accept new baselines

64a864b

Anders Hejlsberg (ahejlsberg) changed the title ~~Improve type inference to allow HKT technique function again~~ Fix isGenericReducibleType to allow HKT technique to function again May 5, 2023

Ryan Cavanaugh (RyanCavanaugh) approved these changes May 19, 2023

View reviewed changes

Anders Hejlsberg (ahejlsberg) merged commit 1ea21e1 into main May 20, 2023

Anders Hejlsberg (ahejlsberg) deleted the fix53970 branch May 20, 2023 13:36

TypeScript Bot (typescript-bot) mentioned this pull request May 22, 2023

🤖 Pick PR #54112 (Fix isGenericReducibleType to all...) into release-5.1 #54349

Merged

Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request May 26, 2023

🤖 Pick PR #54112 (Fix isGenericReducibleType to all...) into releas…

ed924d0

…e-5.1 (#54349) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

Anders Hejlsberg (ahejlsberg) commented May 3, 2023

Uh oh!

Anders Hejlsberg (ahejlsberg) commented May 3, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 3, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 3, 2023

Uh oh!

Jake Bailey (jakebailey) commented May 3, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 3, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 3, 2023

Uh oh!

ecyrbe commented May 3, 2023

Uh oh!

Michael Arnaldi (mikearnaldi) commented May 3, 2023

Uh oh!

Michael Arnaldi (mikearnaldi) commented May 3, 2023

Uh oh!

Anders Hejlsberg (ahejlsberg) commented May 5, 2023

Uh oh!

Anders Hejlsberg (ahejlsberg) commented May 5, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 5, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 5, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 5, 2023

Uh oh!

Jake Bailey (jakebailey) commented May 5, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Michael Arnaldi (mikearnaldi) commented May 5, 2023

Uh oh!

Jake Bailey (jakebailey) commented May 8, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented May 8, 2023

TypeScript Bot (typescript-bot) commented May 3, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 3, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 3, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 3, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 3, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 3, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 3, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 5, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 5, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 5, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 5, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 5, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 5, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 5, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 22, 2023 •

edited

Loading