Widen widening literal types through compound-like assignments by Andarist · Pull Request #52493 · microsoft/TypeScript

Mateusz Burzyński (Andarist) · 2023-01-30T08:55:42Z

# Conflicts: # src/compiler/checker.ts

Mateusz Burzyński (Andarist) · 2023-06-26T22:59:05Z

Ron Buckton (@rbuckton) Jake Bailey (@jakebailey) would you mind taking another look at this? CI is currently failing here for unrelated reasons (see #54791 )

Jake Bailey (jakebailey) · 2023-06-27T02:26:54Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this faster
TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2023-06-27T02:26:57Z

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at d110f3c. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-06-27T02:26:58Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite on this PR at d110f3c. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-06-27T02:26:58Z

Heya Jake Bailey (@jakebailey), I've started to run the abridged perf test suite on this PR at d110f3c. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-06-27T02:26:58Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at d110f3c. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-06-27T02:26:58Z

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at d110f3c. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-06-27T02:26:58Z

Heya Jake Bailey (@jakebailey), I've started to run the tarball bundle task on this PR at d110f3c. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-06-27T02:28:40Z

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155678/artifacts?artifactName=tgz&fileId=644762AD852F5A029C01028F126943F8781935B521CE489313720C10FC374BD102&fileName=/typescript-5.2.0-insiders.20230627.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.2.0-pr-52493-8".;

TypeScript Bot (typescript-bot) · 2023-06-27T02:42:16Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52493

_Metric	_main	₅₂₄₉₃	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{366,030k (± 0.01%)}	_{366,057k (± 0.01%)}	_~	_366,039k	_366,092k	_{p=0.093 n=6}
_{Parse Time}	_{3.59s (± 0.47%)}	_{3.58s (± 0.33%)}	_~	_3.57s	_3.60s	_{p=0.410 n=6}
_{Bind Time}	_{1.18s (± 0.35%)}	_{1.19s (± 0.43%)}	_{+0.01s (+ 0.71%)}	_1.18s	_1.19s	_{p=0.022 n=6}
_{Check Time}	_{9.70s (± 0.55%)}	_{9.66s (± 0.63%)}	_~	_9.58s	_9.76s	_{p=0.171 n=6}
_{Emit Time}	_{8.02s (± 0.77%)}	_{8.00s (± 0.63%)}	_~	_7.95s	_8.08s	_{p=0.687 n=6}
_{Total Time}	_{22.49s (± 0.46%)}	_{22.43s (± 0.44%)}	_~	_22.30s	_22.58s	_{p=0.336 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,805k (± 0.04%)}	_{193,287k (± 0.52%)}	_{+482k (+ 0.25%)}	_192,766k	_195,338k	_{p=0.045 n=6}
_{Parse Time}	_{1.59s (± 0.97%)}	_{1.57s (± 1.77%)}	_~	_1.52s	_1.60s	_{p=0.188 n=6}
_{Bind Time}	_{0.82s (± 0.77%)}	_{0.82s (± 0.92%)}	_~	_0.81s	_0.83s	_{p=0.718 n=6}
_{Check Time}	_{10.11s (± 0.63%)}	_{10.13s (± 0.36%)}	_~	_10.08s	_10.17s	_{p=0.521 n=6}
_{Emit Time}	_{3.04s (± 1.26%)}	_{3.01s (± 0.66%)}	_~	_2.98s	_3.03s	_{p=0.332 n=6}
_{Total Time}	_{15.55s (± 0.45%)}	_{15.53s (± 0.31%)}	_~	_15.47s	_15.59s	_{p=0.423 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{346,073k (± 0.01%)}	_{346,082k (± 0.00%)}	_~	_346,067k	_346,097k	_{p=0.297 n=6}
_{Parse Time}	_{2.73s (± 0.49%)}	_{2.73s (± 0.28%)}	_~	_2.72s	_2.74s	_{p=0.730 n=6}
_{Bind Time}	_{1.09s (± 0.37%)}	_{1.09s (± 1.16%)}	_~	_1.08s	_1.11s	_{p=0.546 n=6}
_{Check Time}	_{7.87s (± 0.60%)}	_{7.87s (± 0.27%)}	_~	_7.85s	_7.91s	_{p=0.872 n=6}
_{Emit Time}	_{4.49s (± 0.48%)}	_{4.47s (± 0.65%)}	_~	_4.43s	_4.50s	_{p=0.290 n=6}
_{Total Time}	_{16.18s (± 0.34%)}	_{16.16s (± 0.31%)}	_~	_16.09s	_16.22s	_{p=0.688 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,218k (± 0.01%)}	_{300,235k (± 0.01%)}	_~	_300,205k	_300,276k	_{p=0.298 n=6}
_{Parse Time}	_{2.16s (± 0.59%)}	_{2.16s (± 0.51%)}	_~	_2.15s	_2.18s	_{p=0.858 n=6}
_{Bind Time}	_{1.24s (± 0.44%)}	_{1.23s (± 1.19%)}	_~	_1.22s	_1.25s	_{p=0.507 n=6}
_{Check Time}	_{7.34s (± 0.39%)}	_{7.32s (± 0.49%)}	_~	_7.26s	_7.35s	_{p=0.260 n=6}
_{Emit Time}	_{4.35s (± 0.53%)}	_{4.34s (± 0.76%)}	_~	_4.28s	_4.37s	_{p=1.000 n=6}
_{Total Time}	_{15.09s (± 0.28%)}	_{15.05s (± 0.30%)}	_~	_14.98s	_15.10s	_{p=0.297 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,651k (± 0.01%)}	_{481,600k (± 0.01%)}	_~	_481,539k	_481,690k	_{p=0.230 n=6}
_{Parse Time}	_{3.26s (± 0.39%)}	_{3.25s (± 0.19%)}	_~	_3.24s	_3.26s	_{p=0.153 n=6}
_{Bind Time}	_{0.95s (± 0.57%)}	_{0.95s (± 0.86%)}	_~	_0.94s	_0.96s	_{p=0.859 n=6}
_{Check Time}	_{17.96s (± 0.62%)}	_{18.02s (± 0.35%)}	_~	_17.94s	_18.09s	_{p=0.335 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.18s (± 0.45%)}	_{22.23s (± 0.30%)}	_~	_22.13s	_22.29s	_{p=0.521 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{561,153k (± 0.02%)}	_{561,197k (± 0.01%)}	_~	_561,123k	_561,329k	_{p=0.336 n=6}
_{Parse Time}	_{4.00s (± 0.41%)}	_{4.00s (± 0.29%)}	_~	_3.99s	_4.02s	_{p=0.681 n=6}
_{Bind Time}	_{1.74s (± 0.47%)}	_{1.73s (± 0.43%)}	_{-0.01s (- 0.67%)}	_1.72s	_1.74s	_{p=0.024 n=6}
_{Check Time}	_{3.06s (± 0.56%)}	_{3.08s (± 0.41%)}	_~	_3.06s	_3.10s	_{p=0.054 n=6}
_{Emit Time}	_{0.09s (± 5.53%)}	_{0.09s (± 5.53%)}	_~	_0.09s	_0.10s	_{p=1.000 n=6}
_{Total Time}	_{8.90s (± 0.29%)}	_{8.90s (± 0.24%)}	_~	_8.88s	_8.93s	_{p=0.466 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₄₉₃	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

TypeScript Bot (typescript-bot) · 2023-06-27T02:53:29Z

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/52493/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

TypeScript Bot (typescript-bot) · 2023-06-27T04:12:40Z

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/52493/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-06-27T04:32:16Z

Hey Jake Bailey (@jakebailey), it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

Jake Bailey (jakebailey) · 2023-08-15T19:27:32Z

TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this faster

Jake Bailey (jakebailey) · 2023-08-15T19:28:16Z

Well, I guess I'll just wait :(

TypeScript Bot (typescript-bot) · 2023-08-15T20:04:52Z

Heya Jake Bailey (@jakebailey), I've started to run the tsc-only perf test suite on this PR at b19223c. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-08-15T20:04:52Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite on this PR at b19223c. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-08-15T20:04:52Z

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at b19223c. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-08-15T20:04:52Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at b19223c. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-08-15T20:21:04Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,320k (± 0.01%)}	_{300,361k (± 0.01%)}	_{+41k (+ 0.01%)}	_300,343k	_300,386k	_{p=0.030 n=6}
_{Parse Time}	_{3.02s (± 0.36%)}	_{3.02s (± 0.13%)}	_~	_3.02s	_3.03s	_{p=1.000 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.93s (± 0.00%)}	_~	_0.93s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{9.48s (± 0.25%)}	_{9.48s (± 0.34%)}	_~	_9.43s	_9.52s	_{p=0.747 n=6}
_{Emit Time}	_{7.64s (± 0.33%)}	_{7.63s (± 0.33%)}	_~	_7.61s	_7.66s	_{p=0.517 n=6}
_{Total Time}	_{21.07s (± 0.22%)}	_{21.06s (± 0.13%)}	_~	_21.03s	_21.09s	_{p=0.871 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,820k (± 0.02%)}	_{193,883k (± 0.01%)}	_{+63k (+ 0.03%)}	_193,858k	_193,899k	_{p=0.020 n=6}
_{Parse Time}	_{1.57s (± 1.36%)}	_{1.58s (± 0.93%)}	_~	_1.55s	_1.59s	_{p=0.396 n=6}
_{Bind Time}	_{0.79s (± 0.52%)}	_{0.79s (± 0.00%)}	_~	_0.79s	_0.79s	_{p=0.405 n=6}
_{Check Time}	_{9.87s (± 0.30%)}	_{9.94s (± 0.30%)}	_{+0.07s (+ 0.73%)}	_9.90s	_9.98s	_{p=0.008 n=6}
_{Emit Time}	_{2.75s (± 0.15%)}	_{2.74s (± 0.30%)}	_~	_2.73s	_2.75s	_{p=0.248 n=6}
_{Total Time}	_{14.98s (± 0.28%)}	_{15.06s (± 0.29%)}	_{+0.08s (+ 0.55%)}	_14.99s	_15.11s	_{p=0.020 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,112k (± 0.01%)}	_{347,132k (± 0.00%)}	_~	_347,115k	_347,158k	_{p=0.078 n=6}
_{Parse Time}	_{2.69s (± 0.39%)}	_{2.68s (± 0.15%)}	_~	_2.68s	_2.69s	_{p=0.528 n=6}
_{Bind Time}	_{0.99s (± 0.41%)}	_{0.99s (± 0.00%)}	_~	_0.99s	_0.99s	_{p=0.405 n=6}
_{Check Time}	_{7.91s (± 0.20%)}	_{7.91s (± 0.27%)}	_~	_7.88s	_7.94s	_{p=0.682 n=6}
_{Emit Time}	_{4.26s (± 0.35%)}	_{4.25s (± 0.32%)}	_~	_4.24s	_4.28s	_{p=0.358 n=6}
_{Total Time}	_{15.85s (± 0.16%)}	_{15.84s (± 0.22%)}	_~	_15.79s	_15.88s	_{p=1.000 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,122k (± 0.00%)}	_{301,137k (± 0.01%)}	_~	_301,113k	_301,157k	_{p=0.229 n=6}
_{Parse Time}	_{2.17s (± 0.54%)}	_{2.17s (± 0.71%)}	_~	_2.15s	_2.19s	_{p=0.869 n=6}
_{Bind Time}	_{1.11s (± 0.00%)}	_{1.11s (± 0.74%)}	_~	_1.09s	_1.11s	_{p=0.405 n=6}
_{Check Time}	_{7.22s (± 0.33%)}	_{7.24s (± 0.17%)}	_~	_7.23s	_7.26s	_{p=0.125 n=6}
_{Emit Time}	_{3.98s (± 0.20%)}	_{3.99s (± 0.63%)}	_~	_3.96s	_4.02s	_{p=0.513 n=6}
_{Total Time}	_{14.49s (± 0.21%)}	_{14.51s (± 0.16%)}	_~	_14.48s	_14.54s	_{p=0.198 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,423k (± 0.01%)}	_{479,429k (± 0.01%)}	_~	_479,380k	_479,480k	_{p=0.936 n=6}
_{Parse Time}	_{3.15s (± 0.13%)}	_{3.15s (± 0.26%)}	_~	_3.15s	_3.17s	_{p=0.218 n=6}
_{Bind Time}	_{0.91s (± 0.00%)}	_{0.91s (± 0.00%)}	_~	_0.91s	_0.91s	_{p=1.000 n=6}
_{Check Time}	_{17.92s (± 0.31%)}	_{17.93s (± 0.28%)}	_~	_17.86s	_17.99s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.98s (± 0.27%)}	_{21.99s (± 0.23%)}	_~	_21.92s	_22.05s	_{p=1.000 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,813k (± 0.01%)}	_{542,812k (± 0.01%)}	_~	_542,724k	_542,944k	_{p=0.873 n=6}
_{Parse Time}	_{3.70s (± 0.20%)}	_{3.70s (± 0.32%)}	_~	_3.68s	_3.71s	_{p=0.796 n=6}
_{Bind Time}	_{1.36s (± 3.97%)}	_{1.36s (± 3.38%)}	_~	_1.33s	_1.45s	_{p=1.000 n=6}
_{Check Time}	_{3.32s (± 2.17%)}	_{3.31s (± 2.02%)}	_~	_3.18s	_3.36s	_{p=0.808 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{8.46s (± 0.46%)}	_{8.46s (± 0.44%)}	_~	_8.39s	_8.49s	_{p=0.936 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2023-08-15T20:31:48Z

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/52493/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

TypeScript Bot (typescript-bot) · 2023-08-15T21:49:25Z

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/52493/merge:

Everything looks good!

Jake Bailey (jakebailey)

Seems good to me now; is there anything left here?

Mateusz Burzyński (Andarist) · 2023-08-15T22:14:19Z

Nothing that I would be aware of :)

TypeScript Bot (typescript-bot) · 2023-08-15T22:15:22Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

…soft#52493)

TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Jan 30, 2023

Widen widening literal types through compound-like assignments

9636938

Mateusz Burzyński (Andarist) force-pushed the fix/widen-compound-like branch from d18dc2c to 9636938 Compare January 30, 2023 08:57

Mateusz Burzyński (Andarist) commented Jan 30, 2023

View reviewed changes

Comment thread src/compiler/utilities.ts Outdated

Mateusz Burzyński (Andarist) commented Jan 30, 2023

View reviewed changes

Comment thread src/compiler/utilities.ts Outdated

Mateusz Burzyński (Andarist) commented Jan 30, 2023

View reviewed changes

Comment thread src/compiler/checker.ts Outdated

Fixed a case around setonly accesstors

f789491

Nathan Shively-Sanders (sandersn) requested review from Jake Bailey (jakebailey) and Ron Buckton (rbuckton) March 7, 2023 19:20

Nathan Shively-Sanders (sandersn) assigned Jake Bailey (jakebailey) Mar 7, 2023

Ron Buckton (rbuckton) suggested changes Apr 12, 2023

View reviewed changes

Comment thread src/compiler/checker.ts Outdated

Comment thread src/compiler/utilities.ts Outdated

Comment thread src/compiler/utilities.ts Outdated

Mateusz Burzyński (Andarist) added 2 commits June 13, 2023 12:59

Merge remote-tracking branch 'origin/main' into fix/widen-compound-like

76c3edc

Merge remote-tracking branch 'origin/main' into fix/widen-compound-like

06e7a27

# Conflicts: # src/compiler/checker.ts

Mateusz Burzyński (Andarist) force-pushed the fix/widen-compound-like branch from fc11bcc to f5a1144 Compare June 26, 2023 22:11

Switch to a separate util

e09ec95

Mateusz Burzyński (Andarist) force-pushed the fix/widen-compound-like branch from f5a1144 to e09ec95 Compare June 26, 2023 22:40

Mateusz Burzyński (Andarist) requested a review from Ron Buckton (rbuckton) June 26, 2023 22:45

Mateusz Burzyński (Andarist) added 2 commits June 27, 2023 00:55

support shift operators

104b97a

Merge remote-tracking branch 'origin/main' into fix/widen-compound-like

d110f3c

Mateusz Burzyński (Andarist) added 2 commits June 27, 2023 10:38

Merge remote-tracking branch 'origin/main' into fix/widen-compound-like

2bbfce4

Merge remote-tracking branch 'origin/main' into fix/widen-compound-like

b19223c

Jake Bailey (jakebailey) approved these changes Aug 15, 2023

View reviewed changes

Jake Bailey (jakebailey) merged commit cac899d into microsoft:main Aug 15, 2023

Marcus Ording (snovader) pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023

Widen widening literal types through compound-like assignments (micro…

dd80cf9

…soft#52493)

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

Mateusz Burzyński (Andarist) commented Jan 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mateusz Burzyński (Andarist) commented Jun 26, 2023

Uh oh!

Jake Bailey (jakebailey) commented Jun 27, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 27, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 27, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 27, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Jun 27, 2023

Uh oh!

Jake Bailey (jakebailey) commented Aug 15, 2023

Uh oh!

Jake Bailey (jakebailey) commented Aug 15, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 15, 2023

Compiler

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 15, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 15, 2023

Uh oh!

Jake Bailey (jakebailey) left a comment

Choose a reason for hiding this comment

Uh oh!

Mateusz Burzyński (Andarist) commented Aug 15, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

TypeScript Bot (typescript-bot) commented Jun 27, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 27, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 27, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 27, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 27, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 27, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Jun 27, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Aug 15, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Aug 15, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Aug 15, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Aug 15, 2023 •

edited

Loading