Fix excess property checking for intersections with index signatures by ahejlsberg · Pull Request #51894 · microsoft/TypeScript

Anders Hejlsberg (ahejlsberg) · 2022-12-14T19:40:17Z

Anders Hejlsberg (ahejlsberg) · 2022-12-14T19:41:07Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test faster
TypeScript Bot (@typescript-bot) test top100

TypeScript Bot (typescript-bot) · 2022-12-14T19:41:10Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based top-repos suite on this PR at d897b56. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-12-14T19:41:10Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at d897b56. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2022-12-14T19:41:10Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at d897b56. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2022-12-14T19:41:10Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based user code test suite on this PR at d897b56. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-12-14T19:41:10Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the abridged perf test suite on this PR at d897b56. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-12-14T19:55:01Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user test suite comparing main and refs/pull/51894/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2022-12-14T20:27:41Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..51894

_Metric	_main	₅₁₈₉₄	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{363,951k (± 0.02%)}	_{363,953k (± 0.02%)}	_{+2k (+ 0.00%)}	_363,837k	_364,081k
_{Parse Time}	_{1.91s (± 0.29%)}	_{1.91s (± 0.58%)}	_{+0.00s (+ 0.10%)}	_1.88s	_1.93s
_{Bind Time}	_{0.66s (± 0.50%)}	_{0.66s (± 0.87%)}	_{+0.00s (+ 0.45%)}	_0.65s	_0.67s
_{Check Time}	_{5.02s (± 0.53%)}	_{5.00s (± 0.73%)}	_{-0.02s (- 0.34%)}	_4.93s	_5.08s
_{Emit Time}	_{4.68s (± 0.97%)}	_{4.71s (± 0.83%)}	_{+0.04s (+ 0.75%)}	_4.60s	_4.78s
_{Total Time}	_{12.26s (± 0.56%)}	_{12.28s (± 0.53%)}	_{+0.02s (+ 0.17%)}	_12.11s	_12.43s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{200,877k (± 0.57%)}	_{201,232k (± 0.50%)}	_{+356k (+ 0.18%)}	_198,534k	_202,074k
_{Parse Time}	_{0.80s (± 0.77%)}	_{0.79s (± 0.70%)}	_{-0.01s (- 0.88%)}	_0.78s	_0.80s
_{Bind Time}	_{0.44s (± 0.91%)}	_{0.44s (± 0.91%)}	_{0.00s ( 0.00%)}	_0.43s	_0.45s
_{Check Time}	_{5.92s (± 0.70%)}	_{5.92s (± 0.83%)}	_{+0.00s (+ 0.03%)}	_5.83s	_6.02s
_{Emit Time}	_{1.79s (± 0.87%)}	_{1.80s (± 0.76%)}	_{+0.01s (+ 0.39%)}	_1.77s	_1.83s
_{Total Time}	_{8.96s (± 0.47%)}	_{8.96s (± 0.57%)}	_{+0.00s (+ 0.03%)}	_8.86s	_9.08s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{346,553k (± 0.01%)}	_{346,533k (± 0.02%)}	_{-20k (- 0.01%)}	_346,348k	_346,641k
_{Parse Time}	_{1.43s (± 0.71%)}	_{1.42s (± 0.53%)}	_{-0.01s (- 0.35%)}	_1.41s	_1.44s
_{Bind Time}	_{0.61s (± 0.85%)}	_{0.61s (± 0.91%)}	_{-0.00s (- 0.16%)}	_0.60s	_0.62s
_{Check Time}	_{4.63s (± 0.37%)}	_{4.63s (± 0.61%)}	_{+0.00s (+ 0.00%)}	_4.57s	_4.70s
_{Emit Time}	_{2.49s (± 0.79%)}	_{2.48s (± 1.53%)}	_{-0.01s (- 0.24%)}	_2.44s	_2.62s
_{Total Time}	_{9.16s (± 0.22%)}	_{9.14s (± 0.68%)}	_{-0.01s (- 0.12%)}	_9.03s	_9.32s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{304,201k (± 0.03%)}	_{304,260k (± 0.01%)}	_{+59k (+ 0.02%)}	_304,119k	_304,321k
_{Parse Time}	_{1.19s (± 1.61%)}	_{1.18s (± 1.19%)}	_{-0.00s (- 0.34%)}	_1.15s	_1.21s
_{Bind Time}	_{0.57s (± 0.86%)}	_{0.57s (± 1.30%)}	_{-0.00s (- 0.17%)}	_0.56s	_0.59s
_{Check Time}	_{4.34s (± 0.23%)}	_{4.34s (± 0.71%)}	_{+0.00s (+ 0.00%)}	_4.27s	_4.42s
_{Emit Time}	_{2.52s (± 1.48%)}	_{2.50s (± 1.48%)}	_{-0.01s (- 0.56%)}	_2.45s	_2.63s
_{Total Time}	_{8.62s (± 0.49%)}	_{8.60s (± 0.71%)}	_{-0.02s (- 0.22%)}	_8.49s	_8.74s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{451,094k (± 0.01%)}	_{451,156k (± 0.02%)}	_{+62k (+ 0.01%)}	_451,017k	_451,297k
_{Parse Time}	_{1.67s (± 0.74%)}	_{1.68s (± 0.65%)}	_{+0.01s (+ 0.48%)}	_1.66s	_1.71s
_{Bind Time}	_{0.50s (± 1.29%)}	_{0.50s (± 0.94%)}	_{-0.00s (- 0.40%)}	_0.49s	_0.51s
_{Check Time}	_{11.71s (± 0.73%)}	_{11.75s (± 0.91%)}	_{+0.04s (+ 0.38%)}	_11.60s	_12.06s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{13.88s (± 0.67%)}	_{13.93s (± 0.86%)}	_{+0.05s (+ 0.37%)}	_13.76s	_14.28s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{551,092k (± 0.00%)}	_{551,261k (± 0.01%)}	_{+169k (+ 0.03%)}	_551,180k	_551,391k
_{Parse Time}	_{2.31s (± 0.70%)}	_{2.29s (± 0.45%)}	_{-0.02s (- 0.74%)}	_2.27s	_2.32s
_{Bind Time}	_{0.85s (± 2.30%)}	_{0.82s (± 2.00%)}	_{🟩-0.03s (- 3.30%)}	_0.78s	_0.85s
_{Check Time}	_{1.35s (± 0.45%)}	_{1.34s (± 0.51%)}	_{-0.01s (- 0.67%)}	_1.32s	_1.35s
_{Emit Time}	_{0.06s (± 0.00%)}	_{0.06s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.06s	_0.06s
_{Total Time}	_{4.57s (± 0.48%)}	_{4.51s (± 0.39%)}	_{-0.06s (- 1.29%)}	_4.47s	_4.54s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-131-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₁₈₉₄	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

TypeScript Bot (typescript-bot) · 2022-12-14T21:36:43Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top-repos suite comparing main and refs/pull/51894/merge:

Something interesting changed - please have a look.

Details

lensapp/lens

5 of 8 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2322: Type 'PartialDeep<Object> & { kind: string; apiVersion: string; metadata: { name: string | undefined; namespace: string | undefined; }; }' is not assignable to type 'PartialObjectDeep<KubeJsonApiData<KubeJsonApiObjectMetadata, unknown, unknown>> | undefined'.
- src/common/k8s-api/kube-api.ts#L563
error TS2322: Type 'PartialDeep<Object> & { metadata: { name: string; namespace: string | undefined; }; }' is not assignable to type 'PartialObjectDeep<KubeJsonApiData<KubeJsonApiObjectMetadata, unknown, unknown>> | undefined'.
- src/common/k8s-api/kube-api.ts#L578

webpack/tsconfig.json

error TS2322: Type 'PartialDeep<Object> & { kind: string; apiVersion: string; metadata: { name: string | undefined; namespace: string | undefined; }; }' is not assignable to type 'PartialObjectDeep<KubeJsonApiData<KubeJsonApiObjectMetadata, unknown, unknown>> | undefined'.
- src/common/k8s-api/kube-api.ts#L563
error TS2322: Type 'PartialDeep<Object> & { metadata: { name: string; namespace: string | undefined; }; }' is not assignable to type 'PartialObjectDeep<KubeJsonApiData<KubeJsonApiObjectMetadata, unknown, unknown>> | undefined'.
- src/common/k8s-api/kube-api.ts#L578

Anders Hejlsberg (ahejlsberg) · 2022-12-15T22:36:18Z

TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test top100

TypeScript Bot (typescript-bot) · 2022-12-15T22:36:51Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based top-repos suite on this PR at e6acb8f. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-12-15T22:36:51Z

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at e6acb8f. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2022-12-16T00:04:39Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top-repos suite comparing main and refs/pull/51894/merge:

Everything looks good!

Anders Hejlsberg (ahejlsberg) added 2 commits December 14, 2022 11:32

Fix excess property checking for intersections with index signatures

959c3aa

Add regression tests

d897b56

TypeScript Bot (typescript-bot) assigned Anders Hejlsberg (ahejlsberg) Dec 14, 2022

TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Dec 14, 2022

Anders Hejlsberg (ahejlsberg) requested review from Daniel Rosenwasser (DanielRosenwasser), Ryan Cavanaugh (RyanCavanaugh) and Nathan Shively-Sanders (sandersn) December 15, 2022 15:44

Ryan Cavanaugh (RyanCavanaugh) approved these changes Dec 15, 2022

View reviewed changes

Limit check to only fresh object literals on the source side

e6acb8f

Anders Hejlsberg (ahejlsberg) merged commit ba793e6 into main Dec 16, 2022

Anders Hejlsberg (ahejlsberg) deleted the fix51875 branch December 16, 2022 14:59

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

Anders Hejlsberg (ahejlsberg) commented Dec 14, 2022

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Dec 14, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 14, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 14, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 14, 2022

lensapp/lens

tsconfig.json

webpack/tsconfig.json

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Dec 15, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TypeScript Bot (typescript-bot) commented Dec 14, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Dec 14, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Dec 14, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Dec 14, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Dec 14, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Dec 15, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Dec 15, 2022 •

edited

Loading