Repository navigation
[moveToNewFile] Fix namespace import update bug, simplify, comment, and rename - #51797
Merged
Andrew Branch (andrewbranch) merged 1 commit intoDec 7, 2022
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Andrew Branch (andrewbranch)
requested review from
Gabriela Araujo Britto (gabritto) and
Isabel Duan (iisaduan)
and removed request for
Isabel Duan (iisaduan)
December 7, 2022 00:10
Gabriela Araujo Britto (gabritto)
approved these changes
Dec 7, 2022
| changes.replaceNode(sourceFile, ref, factory.createIdentifier(newNamespaceName)); | ||
| } | ||
| changes.insertNodeAfter(sourceFile, oldImportNode, updateNamespaceLikeImportNode(oldImportNode, newModuleName, newModuleSpecifier)); | ||
| changes.insertNodeAfter(sourceFile, oldImportNode, updateNamespaceLikeImportNode(oldImportNode, preferredNewNamespaceName, newModuleSpecifier)); |
Member
Author
There was a problem hiding this comment.
This line is the bug fix—everything else was cleanup. newModuleName wasn’t guaranteed to be a valid identifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from a bug I noticed when reviewing #51702
Co-piloted by Isabel Duan (@iisaduan)