Repository navigation
Filter signatures by matching constraints when instantiating them for instantiation signatures - #51695
Conversation
… instantiation signatures
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
| const applicableSignatures = mapDefined(sameTypeAritySignatures, sig => { | ||
| const typeArgumentTypes = checkTypeArguments(sig, typeArguments!, /*reportErrors*/ false); | ||
| return typeArgumentTypes && getSignatureInstantiation(sig, typeArgumentTypes, isInJSFile(sig.declaration)); | ||
| }); |
There was a problem hiding this comment.
Note that this still doesn't exactly work like regular overload selection done by chooseOverload. I simply reject signatures that have non-matching constraints on their type params. When overloads are chosen for call expressions etc the first matching overload "wins".
I think that this is actually desirable - since here we still output an intersection of signatures (overloads) and we leave the final overload selection for the time the output type is being used as a call expression.
| if (applicableSignatures.length) { | ||
| return applicableSignatures; | ||
| } | ||
| return sameMap(sameTypeAritySignatures, sig => { |
There was a problem hiding this comment.
I've preserved the old behavior here~. If there are some signatures for the given type argument arity but when none of them match... I still gonna report the same error. Perpahs this can be improved further.
TypeScript Bot (typescript-bot)
added
For Backlog Bug
|
The TypeScript team hasn't accepted the linked issue #51694. If you can get it accepted, this PR will have a better chance of being reviewed. |
2 similar comments
|
The TypeScript team hasn't accepted the linked issue #51694. If you can get it accepted, this PR will have a better chance of being reviewed. |
|
The TypeScript team hasn't accepted the linked issue #51694. If you can get it accepted, this PR will have a better chance of being reviewed. |
…ntiation-expressions-by-matching-constraints
ff7f0c6 to
ba3e829
Compare
…ntiation-expressions-by-matching-constraints
github-project-automation
Bot
moved this from Waiting on reviewers
to Done
in PR Backlog
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
5 participants
fixes #51694
fixes #63126
There are some open questions related to the design of instantiations expressions and how they relate to overloads etc. But since I was looking into the implementation to see why the reported issue doesn't type-check OK, I've figured out I can create a draft that would address that as the change was fairly easy to introduce.