Repository navigation
Replace eslint-plugin-jsdoc by extending local jsdoc-format rule, saving ~20% of our linting time - #51438
Merged
Jake Bailey (jakebailey) merged 4 commits intoNov 8, 2022
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Sheetal Nandi (sheetalkamat)
approved these changes
Nov 8, 2022
Member
|
Perf is always great |
5 tasks
Jake Bailey (jakebailey)
marked this pull request as ready for review
November 8, 2022 05:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to write an ESLint rule for our JSDoc comments in the module conversion anyway. Extend it to do some basic checking of the alignment of the comments, which is all we use the jsdoc plugin for. (To be clear, I wrote this logic from scratch; the jsdoc plugin probably does a lot more.)
Before:
After:
Probably deserves a test or two; I neglected writing any for my original rule.