Repository navigation
Add Error.prototype.cause - #47020
Merged
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
Nathan Shively-Sanders (sandersn)
requested review from
Orta Therox (orta) and
Ron Buckton (rbuckton)
December 16, 2021 21:46
TypeScript Bot (typescript-bot)
added
For Backlog Bug
Ron Buckton (rbuckton)
approved these changes
Dec 17, 2021
Ron Buckton (rbuckton)
suggested changes
Dec 17, 2021
Ron Buckton (rbuckton)
left a comment
Ron Buckton (rbuckton)
left a comment
Contributor
There was a problem hiding this comment.
Looks good in general, but there are failing tests that need to be addressed.
Kagami Sascha Rosylight (saschanaz)
requested a review
from Ron Buckton (rbuckton)
December 25, 2021 13:59
Contributor
|
Agree, thanks, this all looks good to me too |
2 tasks done
Jakub Stasiak (jstasiak)
added a commit
to lune-climate/ts-results-es
that referenced
this pull request
Mar 29, 2022
I want to have this in place to implement [1] which satisfies a need we ourselves have[2]. This is needed because the cause property is only availble in the es2022 TS profile[3]. [1] vultix#34 [2] vultix#48 [3] microsoft/TypeScript#47020
Jakub Stasiak (jstasiak)
added a commit
to lune-climate/ts-results-es
that referenced
this pull request
Mar 29, 2022
I want to have this in place to implement [1] which satisfies a need we ourselves have[2]. This is needed because the cause property is only availble in the es2022 TS profile[3]. [1] vultix#34 [2] vultix#48 [3] microsoft/TypeScript#47020
| @@ -1,8 +1,55 @@ | |||
| interface ErrorOptions { | |||
| cause?: Error; | |||
| cause?: Error; | |||
There was a problem hiding this comment.
cause should be typed as unknown (or any in a less strict way) as the value being thrown in JavaScript can be arbitrary values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47019