Repository navigation
Don't eagerly simplify reducible generic union index types - #46812
Merged
Wesley Wigham (weswigham) merged 2 commits intoMar 9, 2022
Conversation
Wesley Wigham (weswigham)
requested review from
Anders Hejlsberg (ahejlsberg) and
Nathan Shively-Sanders (sandersn)
November 15, 2021 19:37
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Member
|
TypeScript Bot (@typescript-bot) perf test this |
Contributor
|
Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at 43bfe00. You can monitor the build here. Update: The results are in! |
Contributor
|
Heya Andrew Branch (@andrewbranch), I've started to run the inline community code test suite on this PR at 43bfe00. You can monitor the build here. Update: The results are in! |
Contributor
|
Heya Andrew Branch (@andrewbranch), I've started to run the parallelized Definitely Typed test suite on this PR at 43bfe00. You can monitor the build here. |
Contributor
|
Andrew Branch (@andrewbranch) |
Contributor
|
Andrew Branch (@andrewbranch) Here they are:Comparison Report - main..46812
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
Author
|
All the extended CI results and perf look fine. Reviews please~ |
Andrew Branch (andrewbranch)
approved these changes
Nov 16, 2021
Member
|
Wesley Wigham (@weswigham) Is this ready? Does it need another review? I just noticed it when going through the Needs Merge column of the PR backlog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45530
The issue wasn't that the mapped types were losing information, per sey, in fact, they were responsible for rehydrating missing information in some instances - instead, the issue was that we were too eagerly reducing the
keyofresult of unions over types which might have been reduced upon instantiation, like({v: T} & {v: "a", a: string}) | ({v: T} & {v: "b", b: string}). Before this change,keyofthat was just"v", while now it will remain the generickeyof (({v: T} & {v: "a", a: string}) | ({v: T} & {v: "b", b: string})), since instantiation can make it simplify to eitherkeyof ({v: "a"} & {v: "a", a: string})orkeyof ({v: "b"} & {v: "b", b: string}), which have keys"v" | "a"or"v" | "b", respectively. (Which in turn trickles down to assignability behavior of mapped types over those kinds ofkeyoftypes)