Repository navigation
Reducing tsbuildinfo size further - #43695
Merged
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Sheetal Nandi (sheetalkamat)
marked this pull request as ready for review
April 15, 2021 23:14
Sheetal Nandi (sheetalkamat)
requested a review
from Andrew Branch (andrewbranch)
April 15, 2021 23:14
Andrew Casey (amcasey)
approved these changes
Apr 16, 2021
Andrew Casey (amcasey)
left a comment
Andrew Casey (amcasey)
left a comment
Member
There was a problem hiding this comment.
LGTM. Just measuring against the motivating code base (ETA one hour).
Member
|
tsbuildinfo size dropped from 1345MB to 467MB and total build time dropped ~15%. 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the numbers with one of the internal tsbuildinfo
4de704d Only emit compiler options that affect
a422f9e: Dont emit affectsGlobalScope if its not true
658587d: FileInfo is encoded as string if FileInfo.version === FileInfo.signature && !FileInfo.affectsGlobalScope, otherwise property signature is encoded as false if it was undefined, undefined if FileInfo.version === FileInfo.signature and actual signature otherwise