Repository navigation
Make 'calendar' and 'numberingSystem' open strings in es2020.intl. - #42886
Merged
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit intoFeb 19, 2021
Conversation
Daniel Rosenwasser (DanielRosenwasser)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Orta Therox (orta)
February 19, 2021 20:29
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
Member
Author
|
Long Ho (@longlho) please take a look and let me know whether I've missed anything. |
Member
Author
|
Just as a heads up @batisteo, it looks like we won't be able to keep the change to use union types from #41880. |
Contributor
|
Thanks a lot for the quick fix! LGTM! |
Long Ho (longlho)
approved these changes
Feb 19, 2021
Baptiste Darthenay (blfpd)
approved these changes
Feb 19, 2021
Member
Author
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-4.2 |
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into |
Member
Author
|
And thank you for your patience and persistence - we appreciate the time you took to explain why a revert was the appropriate decision. |
Daniel Rosenwasser (DanielRosenwasser)
deleted the
keepCalendarAndNumberingSystemOpenInIntl2020
branch
February 19, 2021 20:59
Contributor
|
Hey Daniel Rosenwasser (@DanielRosenwasser), I've opened #42888 for you. |
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Feb 19, 2021
Component commits: cfd472f Make 'calendar' and 'numberingSystem' open strings in es2020.intl.
Contributor
|
np happy to help! |
Daniel Rosenwasser (DanielRosenwasser)
added a commit
that referenced
this pull request
Feb 20, 2021
Component commits: cfd472f Make 'calendar' and 'numberingSystem' open strings in es2020.intl. Co-authored-by: Daniel Rosenwasser <Daniel.Rosenwasser@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42885