Repository navigation
Don't allow renaming elements from node_modules - #42434
Closed
Jean Pierre (jeanp413) wants to merge 1 commit into
Closed
Jean Pierre (jeanp413) wants to merge 1 commit into
Jean Pierre (jeanp413) wants to merge 1 commit into
Conversation
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
Member
|
To help with PR housekeeping, I'm going to close this draft PR. It's pretty old. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42367
The new added test it's currently failing so I'm marking this as a draft in the meantime.
In the test,
program.isSourceFileFromExternalLibraryis returningfalsefor/node_modules/lib/index.d.ts, can you point to me what I'm missing?Works fine while testing inside vscode
