Skip to content

No property access from index signature fix - #41793

Merged
Armando Aguirre (armanio123) merged 4 commits into
microsoft:masterfrom
Kingwl:noPropertyAccessFromIndexSignature_fix
Dec 4, 2020
Merged

Armando Aguirre (armanio123) merged 4 commits into
microsoft:masterfrom
Kingwl:noPropertyAccessFromIndexSignature_fix

Conversation

@Kingwl

Copy link
Copy Markdown
Contributor

Fixes #41787
Fixes #41786
Fixes #41785

@Kingwl

Wenlu Wang (Kingwl) commented Dec 3, 2020 •

Copy link
Copy Markdown
Contributor Author

I don't know why the test jsDeclarationsSubclassWithExplicitNoArgumentConstructor changes.
But seems not my bad?

@Kingwl

Copy link
Copy Markdown
Contributor Author

#41803

@@ -0,0 +1,16 @@
/// <reference path='fourslash.ts'/>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of the file is incorrect.

@Kingwl

Copy link
Copy Markdown
Contributor Author

Orta Therox (@orta)
Could TypeScript Bot (@typescript-bot) merge master & push automatically?
Or Github has similar features In my memory, but I haven't seen in this repo.

@Kingwl
Wenlu Wang (Kingwl) force-pushed the noPropertyAccessFromIndexSignature_fix branch from d298975 to 4f8fde3 Compare December 4, 2020 04:47
@armanio123
Armando Aguirre (armanio123) merged commit 3c7ac73 into microsoft:master Dec 4, 2020
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

5 participants