Repository navigation
Fix crash intersecting dynamic import w/esModuleInterop - #40249
Merged
Nathan Shively-Sanders (sandersn) merged 4 commits intoSep 1, 2020
Merged
Nathan Shively-Sanders (sandersn) merged 4 commits into
Nathan Shively-Sanders (sandersn) merged 4 commits into
Conversation
The dynamic import shim creates a symbol without some properties that the intersection-creating code assumes are present as of #38673. This PR adds the smallest possible set of properties to avoid the crash. I'm not sure what others would be good to add.
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Nathan Shively-Sanders (sandersn)
requested a review
from Wesley Wigham (weswigham)
August 25, 2020 20:18
Member
Author
|
From discussion with Wesley Wigham (@weswigham), we decided that getResolvedMembersOrExportsOfSymbol should skip symbols with an undefined |
Wesley Wigham (weswigham)
approved these changes
Aug 26, 2020
Nathan Shively-Sanders (sandersn)
deleted the
fix-crash-intersecting-esmoduleinterop-import
branch
September 1, 2020 16:10
Thibault Malbranche (Titozzz)
pushed a commit
to Brigad/TypeScript
that referenced
this pull request
Sep 7, 2020
) * Fix crash intersecting dynamic import w/esModuleInterop The dynamic import shim creates a symbol without some properties that the intersection-creating code assumes are present as of microsoft#38673. This PR adds the smallest possible set of properties to avoid the crash. I'm not sure what others would be good to add. * Use symbol's declarations instead * Fix getResolvedMembersOrExportsOfSymbol instead * comment from code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dynamic import shim creates a symbol without some properties that the intersection-creating code assumes are present as of #38673.
This PR adds the smallest possible set of properties to avoid the crash.
Fixes #40239