[Nathan Shively-Sanders (sandersn)]

Nested destructuring doesn't really map to ES imports, and I didn't add any code to support it:

const { utils: { nub, intercalate } } = require('./monopackage')

Previously, isRequireVariableDeclaration walked up binding elements until it reached a variable declaration. This change instead only walks up one binding element and stops. Then it's not bound as an alias and uses the checker-only code to produce types for the nested-imported identifiers.

Fixes #40143

[Wesley Wigham (weswigham)]

While you're right in that there's no existing alias declaration that had a similar shape, updating getTargetOfAliasDeclaration to handle arbitrary nesting for locating the alias target symbol seems doable, no? Most of the checker just sees an alias a "a thing the resolves to another thing" - the shape of the declaration isn't particularly important for much other than resolving/serializing it. (Which, for serializing, you can make it into multiple namespace imports, probably, like you've already done for dotted access)

[Nathan Shively-Sanders (sandersn)]

This pattern is rarely used; it's really only prettier, plus one or two each from eslint, discord and zipkin. I think our time would be a lot better spent by skipping correct emit, falling back to the fake type and asking prettier to test out the beta to see if that's good enough.

(The old fallback needs to stick around for other uses, so fixing this wouldn't let us get rid of it either.)

[Wesley Wigham (weswigham)]

Alright.