Repository navigation
Fix class emit in converted loop body - #36795
Merged
Merged
Conversation
Ron Buckton (rbuckton)
requested a review
from Nathan Shively-Sanders (sandersn)
February 14, 2020 01:29
Contributor
Author
|
Daniel Rosenwasser (@DanielRosenwasser): Once Nathan Shively-Sanders (@sandersn) has reviewed, should we cherry-pick this for 3.8? |
Member
|
No, the bug is several versions old and not worth the risk of a late cherry-pick at this point. |
Nathan Shively-Sanders (sandersn)
approved these changes
Feb 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes class emit in a converted loop body when the class contains TypeScript syntax (i.e., fields).
Fixes #31330