Repository navigation
Don’t use 'import =' for auto-import when esModuleInterop is on unless it’s already been done - #36475
Merged
Andrew Branch (andrewbranch) merged 3 commits intoJan 28, 2020
Conversation
Andrew Branch (andrewbranch)
requested review from
Sheetal Nandi (sheetalkamat) and
Wesley Wigham (weswigham)
January 28, 2020 18:15
Sheetal Nandi (sheetalkamat)
approved these changes
Jan 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29038 more/again. I guess the original behavior was an intentional decision, but it was counter to what I remembered enough that I thought it was a bug.
Before: If
import =and a default import both work (because esModuleInterop is on, and your module target is < ES2015), we would preferimport =unless imports in the same file were already taking advantage of esModuleInterop (by default importing a CommonJS export).After: Reverse that logic. If esModuleInterop is on, we’ll prefer a default import unless there’s already one or more
import =in the file.