Repository navigation
Fix crash on erroneous enum member merged with exported type alias - #36429
Merged
Wesley Wigham (weswigham) merged 1 commit intoJan 24, 2020
Merged
Wesley Wigham (weswigham) merged 1 commit into
Wesley Wigham (weswigham) merged 1 commit into
Conversation
Andrew Branch (andrewbranch)
approved these changes
Jan 24, 2020
| ~~~~~~~~~~~~~~~~~~~~~~ | ||
| !!! error TS2440: Import declaration conflicts with local declaration of 'EnumA'. | ||
| ~~~~~ | ||
| !!! error TS2395: Individual declarations in merged declaration 'EnumA' must be all exported or all local. |
There was a problem hiding this comment.
I find it annoying how this message always comes up even when the two declarations don’t merge (without errors)... just feels like misleading noise. Not related to this PR, though, it happens in a lot of nonsense places (#36237)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash reported in our RWC suite on
master.