Repository navigation
Fix stack overflow in circular assignment declaration - #34543
Nathan Shively-Sanders (sandersn) merged 4 commits into
Conversation
It also needs to have multiple assignments so that it has a ValueModule flag. Fixes #33006
|
This was introduced in #29335, but that test still passes with the fallback calls to getTypeOfFuncClassEnumModule removed. |
|
Oops, forgot that some tests were skipped. The tests do still fail. |
|
After some discussion, I don't think that #29335 is the correct fix; umdNamespaceMergedWithGlobalAugmentationIsNotCircular should still have an error, but a duplicate declaration error instead of a circular reference error. |
|
Since 3.7's beta ends today, I decided on a compromise fix, which is to avoid the fallback for symbols with flag Assignment. Those symbols will have already been checked using the JS code path, so aren't candidates for the special kind of merges handled in #29335. Later I'll see whether I can catch the merge from #29335 in mergeSymbol during checker startup and issue an error there. |
|
Wesley Wigham (@weswigham) the React merge works because we allow aliases to merge with anything. If I resolveSymbol first and forbid merges between the source and the resolved alias, it breaks four tests and the breaks all look right to me. Opinions? |
2 participants
The declaration also needs to have multiple assignments so that it has a ValueModule flag.
The fix is to remove the possibly-circular call to getTypeofFuncClassEnumModule in the circularity-detection code path.
Fixes #33006