Repository navigation
test(ts-toolbelt): recursive iteration types - #33810
Merged
Nathan Shively-Sanders (sandersn) merged 4 commits intoDec 5, 2019
Merged
Conversation
|
|
Contributor
Author
|
I believe the build is failing because of master. Will retry when master is passing its tests again. |
Nathan Shively-Sanders (sandersn)
approved these changes
Oct 15, 2019
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
Looks good with two comments:
- Wesley Wigham (@weswigham) recently changed the user test format. Wesley Wigham (@weswigham) can you make sure this is valid?
- Do you mind commenting at the top that this library is most widely used in ramda?
Contributor
Author
|
Thanks Nathan Shively-Sanders (@sandersn). I just added it. |
Contributor
Author
|
Hey Nathan Shively-Sanders (@sandersn), is this still going to be merged? Or is there anything blocking it? |
Member
|
Sorry, I lost track of this. Thanks for the ping. |
Contributor
Author
|
I can imagine all the stuff you've got on your list. No worries! Thanks for merging 🎉 |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a test for recursive iteration types to preserve ts-toolbelt's recursion capabilities in the future (as discussed with Nathan Shively-Sanders (@sandersn))