Repository navigation
Restore union-like behavior for inference to conditional types - #32208
Merged
Merged
Conversation
Anders Hejlsberg (ahejlsberg)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Wesley Wigham (weswigham)
July 2, 2019 03:51
Wesley Wigham (weswigham)
approved these changes
Jul 2, 2019
Wesley Wigham (weswigham)
left a comment
Wesley Wigham (weswigham)
left a comment
Member
There was a problem hiding this comment.
Should check that that node8 test is passing, too - I restarted it because the failure seemed unrelated (maybe due to a nested dependency) hopefully it's ok on rerun.
Member
|
cc Ron Buckton (@rbuckton) re: the node 8 failure on this PR. That failure looks like it's in an untranspiled optional catch clause in a library you happen to maintain: https://github.com/esfx/esfx/blob/master/internal/deprecate/src/index.ts |
Contributor
|
Should be fixed now. I restarted the node 8 build and it passed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31766.