Repository navigation
Dont create a union type to infer conditional type branches - #30010
Merged
Wesley Wigham (weswigham) merged 1 commit intoFeb 26, 2019
Merged
Wesley Wigham (weswigham) merged 1 commit into
Wesley Wigham (weswigham) merged 1 commit into
Conversation
Contributor
|
This also addresses a core problem we're seeing in #30029 |
Anders Hejlsberg (ahejlsberg)
approved these changes
Feb 26, 2019
Contributor
|
Wesley Wigham (@weswigham) Can you also take a look at #30049 #30047? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29945
This was actually substantially simpler to fix than I initially thought. Turns out the only issue is that when we infer from a union to another union, we lop off the common members before inferring to a type parameter in that union. For conditional types, doing this to the union of both branches isn't what we'd like to have happen, so instead we just infer to each branch separately to skip the top level union inference logic.