Skip to content

There is no need to check for file presence when trying to rename imports based on file rename - #29313

Merged
Sheetal Nandi (sheetalkamat) merged 1 commit into
masterfrom
getEditsForRename
Jan 9, 2019
Merged

Sheetal Nandi (sheetalkamat) merged 1 commit into
masterfrom
getEditsForRename

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Jan 8, 2019 •

Copy link
Copy Markdown
Member

Fixes #29031
The perf changed from about 5.7s to 426ms

Info 1889 [15:23:1.527] request:
    {"seq":33,"type":"request","command":"getEditsForFileRename","arguments":{"file":"c:/github/vscode/src/vs/base/common/newPaging.ts","oldFilePath":"c:/github/vscode/src/vs/base/common/paging.ts","newFilePath":"c:/github/vscode/src/vs/base/common/newPaging.ts"}}
Perf 1890 [15:23:1.954] 33::getEditsForFileRename: elapsed time (in milliseconds) 426.4376

@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the getEditsForRename branch January 9, 2019 00:24
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants