Repository navigation
Fix crash on umd and module merge, allow umds to be accessed when merged with a non-UMD symbol - #28782
Conversation
…ged with a non-UMD symbol
| } | ||
|
|
||
| a.x + a.y + a.z + a.conflict; | ||
| ~ |
There was a problem hiding this comment.
Wasn't that error correct?
There was a problem hiding this comment.
Not really, no. If there's a global augmentation adding a thing to the global scope, then it should be globally accessible, period.
There was a problem hiding this comment.
But aren't the globals accessible from module? They are only accessible from non module file?
There was a problem hiding this comment.
Today, the umd declaration poisons the symbol unconditionally (irrespective of other things the symbol may have merged with). With this change, the UMD declaration only errors on access if every declaration of the symbol is a UMD declaration.
|
Works for me 😄 |
|
Daniel Rosenwasser (@DanielRosenwasser) since this fixes a crash, do we want to port it to 3.2? |
|
This is an active 3.2 blocker for a few of our repos so I'd very much appreciate it 😄 |
|
+1 this is a blocker for my project as well, much appreciated if this fix can be released soon. |
|
Yesterday's nightly should've included the fix, so installing |
Thanks, works for me 😀 |
4 participants
Fixes #28762