Repository navigation
Fix definitely assignable relation - #28718
Merged
Anders Hejlsberg (ahejlsberg) merged 3 commits intoNov 29, 2018
Merged
Conversation
Anders Hejlsberg (ahejlsberg)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Wesley Wigham (weswigham)
November 28, 2018 23:05
Wesley Wigham (weswigham)
approved these changes
Nov 29, 2018
Wesley Wigham (weswigham)
left a comment
Wesley Wigham (weswigham)
left a comment
Member
There was a problem hiding this comment.
I suppose not including the unsound index constraint assignability rule in definitely assignable is better than doing so.
Daniel Rosenwasser (DanielRosenwasser)
deleted the
fixDefinitelyAssignableRelation
branch
November 29, 2018 02:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28654.