Skip to content

Fix mixin logic to preserve at least one constructor type even when the intersection also contains non-constructor types. - #27701

Merged
Wesley Wigham (weswigham) merged 2 commits into
microsoft:masterfrom
mattmccutchen:issue-17388
Mar 12, 2019
Merged

Fix mixin logic to preserve at least one constructor type even when the intersection also contains non-constructor types.#27701
Wesley Wigham (weswigham) merged 2 commits into
microsoft:masterfrom
mattmccutchen:issue-17388

Conversation

@mattmccutchen

@mattmccutchen Matt McCutchen (mattmccutchen) commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

Fixes #17388.

Closed
@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Jan 24, 2019

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at a8b6164. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Jan 24, 2019

Copy link
Copy Markdown
Member

Willing to merge this if RWC is green or greenish

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Jan 25, 2019

Copy link
Copy Markdown
Member

Wesley Wigham (@weswigham) the RWC PR doesn't match this at all - definitely a bunch of unrelated changes. Can you investigate?

@weswigham

Wesley Wigham (weswigham) commented Jan 25, 2019

Copy link
Copy Markdown
Member

Ryan Cavanaugh (@RyanCavanaugh) you need to merge master into this PR - the RWC runner runs with the PR head, not the merge result

@mattmccutchen
Fix mixin logic to preserve at least one constructor type even when the
a724427 
intersection also contains non-constructor types.

Fixes microsoft#17388.
@mattmccutchen

Matt McCutchen (mattmccutchen) commented Feb 9, 2019

Copy link
Copy Markdown
Contributor Author

Updated to master. Please try the RWC again.

@weswigham

Wesley Wigham (weswigham) commented Feb 9, 2019

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the extended test suite on this PR at a724427. You can monitor the build here. It should now contribute to this PR's status checks.

@weswigham

Wesley Wigham (weswigham) commented Mar 12, 2019

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the extended test suite on this PR at d54833b. You can monitor the build here. It should now contribute to this PR's status checks.

@weswigham

Wesley Wigham (weswigham) commented Mar 12, 2019

Copy link
Copy Markdown
Member

Noice, RWC's clean, time to merge

@weswigham
Wesley Wigham (weswigham) merged commit ab81536 into microsoft:master Mar 12, 2019
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) RyanCavanaugh approved these changes

Assignees

@weswigham Wesley Wigham (weswigham)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mattmccutchen @RyanCavanaugh @typescript-bot @weswigham