Repository navigation
Limit the narrow-to-fresh rule added with boolean literals to only boolean literals (#27274) - #27319
Merged
Wesley Wigham (weswigham) merged 1 commit intoSep 24, 2018
Conversation
…olean literals (microsoft#27274) * Remove the narrow-to-fresh rule added with boolean literals * Revert "Remove the narrow-to-fresh rule added with boolean literals" This reverts commit 9f96fe5. * Only apply freshness to booleans for now * Add largeish example from issue * Should be AND not OR * Add minor improvements suggested by @ahejelsberg * Reorder conditional a bit
Wesley Wigham (weswigham)
requested a review
from Ryan Cavanaugh (RyanCavanaugh)
September 24, 2018 19:39
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Sep 24, 2018
Wesley Wigham (weswigham)
deleted the
port-frshness-propegation-limiter
branch
September 24, 2018 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #27274 to
release-3.1.