Skip to content

fix lookup regression again and again - #26810

Merged
Ryan Cavanaugh (RyanCavanaugh) merged 4 commits into
microsoft:masterfrom
Kingwl:fix_lookup_regression_again_and_again
Oct 10, 2018
Merged

fix lookup regression again and again#26810
Ryan Cavanaugh (RyanCavanaugh) merged 4 commits into
microsoft:masterfrom
Kingwl:fix_lookup_regression_again_and_again

Conversation

@Kingwl

@Kingwl Wenlu Wang (Kingwl) commented Aug 31, 2018

Copy link
Copy Markdown
Contributor

Fixes #26808

hope do not fix again and again and again🤷🏻‍♂️

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Aug 31, 2018

Copy link
Copy Markdown
Member

Wenlu Wang (@Kingwl) thank you for your persistence and timely responses on this! Obviously we are starting to get a little worried - #26813 also just came up, though it appears to be fixed by this PR.

I'm going to revert the prior two PRs and ask that you submit a fresh PR with this fix and the prior ones all rolled into one, along with testcases. I'll put the tests in the revert PR, along with an extracted repro from #26813, so that we can more easily review the changes together and make sure the right thing is happening.

Thanks again!

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Aug 31, 2018

Copy link
Copy Markdown
Member

#26820 is in now, so please rebase

@Kingwl

Wenlu Wang (Kingwl) commented Sep 1, 2018

Copy link
Copy Markdown
Contributor Author

sorry about that😅

@Kingwl

Wenlu Wang (Kingwl) commented Sep 3, 2018

Copy link
Copy Markdown
Contributor Author

updated

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Sep 5, 2018

Copy link
Copy Markdown
Member

Anders Hejlsberg (@ahejlsberg) this is the cleaned-up PR we discussed last week

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Oct 9, 2018

Copy link
Copy Markdown
Member

Wenlu Wang (@Kingwl) can you fix the merge conflict? Sorry for the delay

@Kingwl

Wenlu Wang (Kingwl) commented Oct 10, 2018

Copy link
Copy Markdown
Contributor Author

sure, a few moments later

@Kingwl
Wenlu Wang (Kingwl) force-pushed the fix_lookup_regression_again_and_again branch from 7763347 to 20054d9 Compare October 10, 2018 07:24
@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Oct 10, 2018

Copy link
Copy Markdown
Member

Looks good; let's see what shows up in nightly feedback 😅

@RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) merged commit fc78839 into microsoft:master Oct 10, 2018
@Kingwl
Wenlu Wang (Kingwl) deleted the fix_lookup_regression_again_and_again branch October 11, 2018 01:01
@Kingwl

Wenlu Wang (Kingwl) commented Oct 27, 2018

Copy link
Copy Markdown
Contributor Author

seems everything is ok 😆

@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ajafff Klaus Meinhardt (ajafff) ajafff approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

TypeScript 3.3

Development

Successfully merging this pull request may close these issues.

wrong referenced symbol in parameter intializer

3 participants

@Kingwl @RyanCavanaugh @ajafff