Repository navigation
Merged
Conversation
ghost
requested a review
from Nathan Shively-Sanders (sandersn)
August 17, 2018 15:49
Nathan Shively-Sanders (sandersn)
approved these changes
Aug 17, 2018
ghost
deleted the
fix_lint
branch
August 17, 2018 16:13
Brendan Forster (shiftkey)
added a commit
to desktop/desktop
that referenced
this pull request
Sep 7, 2018
this has been fixed in microsoft/TypeScript#26515 but for some reason wasn't published with TS 3.0.3
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to #26424 these non-null assertions are now unnecessary.