Repository navigation
Mark error type in type baselines if the baselines otherwise seem clean - #26346
Merged
Wesley Wigham (weswigham) merged 1 commit intoAug 17, 2018
Merged
Conversation
Wesley Wigham (weswigham)
changed the title
Wesley Wigham (weswigham)
requested a review
from Ryan Cavanaugh (RyanCavanaugh)
August 9, 2018 23:04
Sheetal Nandi (sheetalkamat)
approved these changes
Aug 10, 2018
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Aug 10, 2018
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this iteration, only
any's in files from certain locations that we're pretty sure aren't almost guaranteed to be anerrorare marked (and only in files without any diagnostics). There's a exactly one indexed access instantiation (indexingTypesWithNever.types), but mostly JSX tests with no JSX.Element type defined.