Repository navigation
importFixes: When one file redirects to another, consider both for global import specifiers - #25834
Merged
7 commits merged intoAug 1, 2018
Merged
7 commits merged into
7 commits merged into
Conversation
…obal import specifiers
ghost
requested a review
from Sheetal Nandi (sheetalkamat)
July 20, 2018 21:57
Contributor
|
Wesley Wigham (@weswigham) can you also take a look. seems related to the .d.ts issue |
Member
|
Mohamed Hegazy (@mhegazy) Well, #25850 definitely conflicts with this. 😄 |
ghost
force-pushed
the
duplicatePackageImportFixes
branch
from
July 25, 2018 17:02
b3d901f to
06f0ba5
Compare
ghost
force-pushed
the
duplicatePackageImportFixes
branch
from
July 25, 2018 18:39
06f0ba5 to
2d955a3
Compare
ghost
force-pushed
the
duplicatePackageImportFixes
branch
from
July 30, 2018 23:15
2dcac53 to
15b8af7
Compare
ghost
force-pushed
the
duplicatePackageImportFixes
branch
from
July 31, 2018 00:04
b7f1c21 to
6d83f95
Compare
| // KLUDGE: Don't assume one 'node_modules' links to another. More likely a single directory inside the node_modules is the symlink. | ||
| // ALso, don't assume that an `@foo` directory is linked. More likely the contents of that are linked. | ||
| function isNodeModulesOrScopedPackageDirectory(s: string): boolean { | ||
| return s === "node_modules" || startsWith(s, "@"); |
Member
There was a problem hiding this comment.
node_modules comparison should (probably) use platform case comparison, for completeness.
Wesley Wigham (weswigham)
approved these changes
Jul 31, 2018
Wesley Wigham (weswigham)
left a comment
Wesley Wigham (weswigham)
left a comment
Member
There was a problem hiding this comment.
Small nit, but looks good.
ghost
deleted the
duplicatePackageImportFixes
branch
August 1, 2018 00:28
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25279 (comment)