Repository navigation
In insertNodeAfter, handle file with no trailing newline - #23814
Merged
1 commit merged intoMay 3, 2018
Merged
1 commit merged into
1 commit merged into
Conversation
ghost
requested a review
from Andrew Casey (amcasey)
May 1, 2018 22:39
ghost
force-pushed
the
insertNodeAfter_fileWithNoTrailingNewline
branch
from
May 2, 2018 16:38
2cb684c to
f5571e8
Compare
Andrew Casey (amcasey)
approved these changes
May 2, 2018
Andrew Casey (amcasey)
left a comment
Andrew Casey (amcasey)
left a comment
Member
There was a problem hiding this comment.
Seems like there might be a corner case at BOF. Otherwise, LGTM.
| description: "Convert function to an ES2015 class", | ||
| newFileContent: | ||
| `/** Doc */ | ||
| ` |
There was a problem hiding this comment.
This doesn't seem great. What is the comment being inserted after that is resulting in the blank line?
Author
There was a problem hiding this comment.
The way convertFunctionToEs6Class works, we are deleting the function and adding a class node after it. In textChanges we don't know that the function is going to be deleted, so we add a newline to separate the old function and the new class. Added an issue at #23871
Mohamed Hegazy (mhegazy)
approved these changes
May 3, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23728