Repository navigation
Fix implied constraints in conditional types - #22989
Merged
Merged
Conversation
Anders Hejlsberg (ahejlsberg)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Mohamed Hegazy (mhegazy)
March 29, 2018 17:24
| function getConstrainedTypeVariable(typeVariable: TypeVariable, node: Node) { | ||
| let constraints: Type[]; | ||
| while (isPartOfTypeNode(node)) { | ||
| while (node && !isStatement(node)) { |
There was a problem hiding this comment.
Is isExpression preferable to isStatement here?
Member
Author
There was a problem hiding this comment.
No, there might not be an enclosing expression anywhere in the parent chain.
Member
Author
There was a problem hiding this comment.
We could additionally check for !isExpression(node) but it isn't really necessary, we'll eventually hit a statement (which could be a declaration statement) or the very top node.
Mohamed Hegazy (mhegazy)
approved these changes
Mar 29, 2018
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Mar 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22985.